Add new flag "--ports" to expose ports for docker & podman drivers #9404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
|
Welcome @toonvanstrijp! |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @toonvanstrijp. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ToonvanStrijp The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
Travis tests have failedHey @toonvanstrijp, 1st Buildmake testTravisBuddy Request Identifier: f556a7d0-07c9-11eb-a712-35638fe859f6 |
toonvanstrijp
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @sharifelgamal |
medyagh
requested changes
Oct 6, 2020
|
Not an admin here, but I was analyzing the changes, and I have a question: as the start command already binds some ports to the 127.0.0.1 IP address, if the user choose to expose those ports will them be bound to the correct IP for exposure (0.0.0.0 or any other supplied)? That is, if the user provides custom ports (including the default ones), those have to have priority over the default ones. |
k8s-ci-robot
added
size/M
toonvanstrijp
changed the title
Travis tests have failedHey @toonvanstrijp, 1st Buildmake testTravisBuddy Request Identifier: 77db4490-08ba-11eb-9b15-83942378e0dd |
k8s-ci-robot
added
size/S
medyagh
changed the title
medyagh
approved these changes
Oct 7, 2020
This was referenced Apr 26, 2021
|
It's important to note that the e.g. Probably I'm a bit dim, but it took me a couple of hours to work this out, so posting it here in the hope that it helps someone else. |
|
What would be the syntax if I need to have 2 minikube nodes (docker). I tried the below with no luck: $ minikube start --nodes 2 --driver=docker --ports=":30778" --ports=":9001" ❌ Exiting due to MK_USAGE: Sorry, one of the ports provided with --ports flag is not valid [:30778 :9001] |
|
Seems that for multi-node minikube the --ports parameter is also sent to the workers causing a "port is already allocated" error because the ports were already assigned while launching the first minikube container instance. (minikube version 1.26.0) minikube start --driver=docker --nodes=2 --ports=9000:9000 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose extra ports when using docker driver. This fixes issue: #8008 #8398 #9198
Usage:
Please let me know if changes are necessary 😃