Do not auto-select Hyper-V driver if session has no privilege #9588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
medyagh
requested changes
Oct 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #9588 +/- ##
=======================================
Coverage 29.04% 29.05%
=======================================
Files 172 172
Lines 10499 10506 +7
=======================================
+ Hits 3049 3052 +3
- Misses 7025 7029 +4
Partials 425 425
|
tstromberg
suggested changes
Nov 10, 2020
k8s-ci-robot
added
size/M
|
@blueelvis do you mind updating the pr description with new output and also pull master And ensure when not in admin privileges, minikube moves to the next available driver (virtualbox or whatever available) instead of exiting ? |
medyagh
requested changes
Nov 17, 2020
medyagh
approved these changes
Nov 23, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: blueelvis, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks for both of the following -
Without the administrator permission, the config file is not saved and the driver is not auto selected and saved.
Output without Admin privilege & Docker offline -
Output without Admin privilege & Docker online -
Output with Administrator privilege & Docker offline -
