Add ssh-host command for getting the ssh host keys #9630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
Travis tests have failedHey @afbjorklund, 1st Buildmake testTravisBuddy Request Identifier: 932e8930-2121-11eb-a20b-45518f503c27 |
|
Can you explain in your PR what the problem is that you are trying to solve, and why the approach this PR takes is the best way to go about solving this problem? It would help to provide context. |
Will do, we broke this PR out from the other work - so it lost the context |
|
Added context to PR description. |
afbjorklund
force-pushed
the
ssh-host
branch
from
44e3499 to
50df1b7
Compare
medyagh
approved these changes
Nov 27, 2020
|
@afbjorklund please check unit test |
Unrelated to PR, I think ? The help was broken, but fixed by PR #9632 |
medyagh
approved these changes
Dec 8, 2020
medyagh
requested changes
Dec 8, 2020
medyagh
approved these changes
Dec 9, 2020
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
kvm2 Driver |
afbjorklund
force-pushed
the
ssh-host
branch
from
fe44cf2 to
ce40816
Compare
|
Error: running mkcmp |
|
kvm2 Driver Times for Minikube (PR 9630): 61.1s 62.8s 58.7s Averages Time Per Log docker Driver Times for Minikube (PR 9630): 28.1s 28.0s 27.2s Averages Time Per Log |
|
Somebody broke the documentation on master, failing the unit tests (fix in |
This is similar to the existing minikube "ssh-key" command, but gets the content of the host key instead of the path to the identity key. The output of this command can be added to the ~/.ssh/known_hosts, for strict host key authentication. For instance when using Docker.
This matches the ssh-add command for identity keys, it will add the host key to the ssh known_hosts file. If a ssh key for the host already exists in the file, it will not be added again so can be run multiple times.
afbjorklund
force-pushed
the
ssh-host
branch
from
ce40816 to
7822a4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to the existing minikube "ssh-key" command, but gets
the content of the host key instead of the path to the identity key.
The output of this command can be added to the ~/.ssh/known_hosts,
for strict host key authentication. For instance when using Docker.
If you don't set up the host as known ahead of time, you will get a question:
Or graphical equivalent: #9229 (comment)
Adding the host key to the "known_hosts" file, avoids this interactive question.
The host keys are retrieved using the command:
Using
minikube sshavoids the question by ignoring host keys*, but that option is less secureand not available when using the Docker
ssh://URL, which requires setting up the ssh keys.*
-o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/nullCurrently hardcoded to use ssh-rsa (only). To avoid having three lines added per host/machine.
For #9229
And #9548