Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubernetes dashboard to v2.1.0 for 1.20 #9963

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

afbjorklund
Copy link
Collaborator

Now with support for Kubernetes version 1.20 too

https://github.com/kubernetes/dashboard/releases/tag/v2.1.0

Now with support for Kubernetes version 1.20 too
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@afbjorklund
Copy link
Collaborator Author

This will probably affect the preload

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this will just require a bump in preload version so that the new image is included:

PreloadVersion = "v7"

@afbjorklund
Copy link
Collaborator Author

And the bump is done just before generating the release preload, right ?

@priyawadhwa
Copy link

Yup, once the PR is merged then the release will kick off

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Dec 15, 2020

@priyawadhwa : my question was actually if it should be included in this commit

Or if there will be a separate preload version bump, later on ? (in the release process)

@priyawadhwa
Copy link

Ah, sorry! I think it's fine to include it in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants