Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCensus and gopsutil as dependency #289

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

xueweiz
Copy link
Contributor

@xueweiz xueweiz commented Jun 6, 2019

These two libraries are needed for #275 to compile.

The changes were made & merged first at #286 . But since then, NPD has switched from Godep to Go Modules (#287 ). This change is re-adding these libraries using Go Modules.

Test: rebase #275 on top of this, and then #275 compiles correctly.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @xueweiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 6, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Jun 6, 2019

This is also part of #284

@xueweiz
Copy link
Contributor Author

xueweiz commented Jun 6, 2019

/assign @wangzhen127
/cc @andyxning

go.sum Show resolved Hide resolved
@andyxning
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2019
@andyxning
Copy link
Member

andyxning commented Jun 6, 2019

The changes were made & merged first at #286 . But since then, NPD has switched from Godep to Go Modules (#287 ). This change is re-adding these libraries using Go Modules.

If go modules are added after #286, then these packages should be transformed to go modules. Anyway, let's ensure that they are added by go modules.

@xueweiz Thanks for the job.

@andyxning
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 831f7fb into kubernetes:master Jun 6, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Jun 6, 2019

Thanks so much for the prompt review @andyxning !

If go modules are added after #286, then these packages should be transformed to go modules.
Yeah, but the problem is that as part of #287 , the unused libraries (i.e. included in /vendor, but not imported any where) got trimmed.
The code that imports OpenCensus and gopsutil are still in the review queue. So these two libraries got identified as unused libraries, and got deleted :)

@andyxning
Copy link
Member

The code that imports OpenCensus and gopsutil are still in the review queue. So these two libraries got identified as unused libraries, and got deleted :)

You reminds me. :)

@xueweiz xueweiz mentioned this pull request Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants