REQUEST: Create kubernetes-sigs/noderesourcetopology-api

[swatisehgal]

New repo, staging repo, or migrate existing

new repository

Is it a staging repo?

no

Requested name for new repository

noderesourcetopology-api

Which Organization should it reside

kubernetes-sigs

Who should have admin access?

swatisehgal, ffromani

Who should have write access?

marquiz

Who should be listed as approvers in OWNERS?

swatisehgal, ffromani, marquiz

Who should be listed in SECURITY_CONTACTS?

swatisehgal, ffromani, marquiz

What should the repo description be?

CRD based API to capture Node Resource Topology information

What SIG and subproject does this fall under?

sig-node, subproject: resource-management

Please provide references to appropriate approval for this new repo

1. Input received during API review: Remove NodeResourceTopology API from staging kubernetes#96275 (comment). Previously the API was being proposed under staging but that proposal was rejected and it was recommended to propose this under kubernetes-sigs.
2. Had a discussion in SIG Node meeting on 23/05/2023 to get everyone upto speed on the input received from the API reviewers and identify the best course of action for this repo.

Additional context for request

1. NFD Topology Updater in kubernetes-sigs/node-feature-discovery and Topology aware scheduler plugin in kubernetes-sigs/scheduler-plugins both depend on this API.
2. Issue: empty noderesourcetopology-api repository in kubernetes-sigs community#6308
3. Related work: Noderesourcetopology- api: Repo Bootstrap kubernetes#110252 and Remove NodeResourceTopology API from staging kubernetes#96275

[swatisehgal]

/cc @ffromani @marquiz

[ffromani]

thanks @swatisehgal . Fully makes sense to me because both https://github.com/kubernetes-sigs/scheduler-plugins and https://github.com/kubernetes-sigs/node-feature-discovery both depend on this API.

[swatisehgal]

/cc @liggitt

[pacoxu]

Should this include sig scheduling?

[swatisehgal]

Should this include sig scheduling?

@pacoxu I believe that this falls primarily under SIG Node as this API exposes node specific information that can be used for various use cases one of which is Topology aware scheduling. There could be other components that could use this API such as DRA controller.

Having said that, I would be more than happy to have input from sig scheduling on this.

[kad]

+1 for creating that repository and moving development of those CRDs under official Kubernetes umbrella.

[swatisehgal]

/sig node
(as the primary SIG)

/sig scheduling
(for input)

[liggitt]

A sigs repo for this makes sense to me, so 👍

Since this contains a k8s.io API which falls under API review, please ensure the directories containing the API definitions (go types and/or CRD manifests) require API approval to merge changes to those definitions

[swatisehgal]

A sigs repo for this makes sense to me, so +1

Since this contains a k8s.io API which falls under API review, please ensure the directories containing the API definitions (go types and/or CRD manifests) require API approval to merge changes to those definitions

Will do, Thanks!

[mrbobbytables]

/assign @dchen1107 @derekwaynecarr @mrunalp
for signoff from sig node TLs

[SergeyKanzhelev]

/assign @dchen1107 @derekwaynecarr @mrunalp for signoff from sig node TLs

It was discussed at SIG Node meeting at 05/23 and approved. @dchen1107 @derekwaynecarr @mrunalp can one of you formally approve it here?

[dchen1107]

/approve

Discussed and reviewed and approved at SIG Node meeting on 5/23. Thanks!

[mrbobbytables]

I'm confused - the repo does exist already and has been populated. What is the action being requested? :x

[swatisehgal]

I'm confused - the repo does exist already and has been populated.

Previously the API was being proposed under staging and was bootstrapped with owner file/ readme etc. The API was NOT populated initially. During the review process of the follow-up PR that tried to populate the API, the proposal was rejected and it was recommended to propose the API under kubernetes-sigs and we are requesting a repo to be created (under kubernetes-sigs) in this issue for that.

I pivoted that PR to remove the repo from staging based on the input received. I am not sure why https://github.com/kubernetes/noderesourcetopology-api/ wasn't removed in spite of its removal from k/k/staging.

Hope this helps.

What is the action being requested? :x

This request is to create a repo under kubernetes-sigs which can be populated with the CRD based API in the coming release(s) with reviews from other community members and API reviewers.

[mrbobbytables]

I pivoted that PR to remove the repo from staging based on the input received. I am not sure why https://github.com/kubernetes/noderesourcetopology-api/ wasn't removed in spite of its removal from k/k/staging.

staging repos are not removed automatically, they have to be cleaned up separately

So - just to be clear, the repo is 100% good to delete and recreate, correct? - I just don't want to inadvertently delete something that is needed

[swatisehgal]

Yes, please go ahead and delete https://github.com/kubernetes/noderesourcetopology-api/.

The new repo should be created under kubernetes-sigs: https://github.com/kubernetes-sigs/noderesourcetopology-api.

[mrbobbytables]

/assign

[mrbobbytables]

update test-infra to remove staging rule for previous repo: kubernetes/test-infra#30037
repo created: https://github.com/kubernetes-sigs/noderesourcetopology-api
teams added: #4323
k/community update: kubernetes/community#7390

Once those PRs are merged I'll add the teams to the repo and finish removing the staging repo.

[mrbobbytables]

teams have been added - just waiting on the branch protection rule to be removed before I archive the staging repo

[mrbobbytables]

everything has merged, old staging repo has been archived. Going to go ahead and close this out.

Thanks!

/close

[k8s-ci-robot]

@mrbobbytables: Closing this issue.

In response to this:

everything has merged, old staging repo has been archived. Going to go ahead and close this out.

Thanks!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.