migrate osbkit/minibroker to kubernetes-sigs/minibroker

[jberkhahn]

New Repo, Staging Repo, or migrate existing

migrate existing github.com/osbkit/minibroker

Requested name for new repository

minibroker

Which Organization should it reside

kubernetes-sigs

If not a staging repo, who should have admin access

the kubernetes-sigs team service-catalog-admins

If not a staging repo, who should have write access

the kubernetes-sigs team service-catalog-maintainers

If not a staging repo, who should be listed as approvers in OWNERS

the kubernetes-sigs team service-catalog-maintainers

If not a staging repo, who should be listed in SECURITY_CONTACTS

jberkhahn

What should the repo description be

A minibroker for your minikube!

What SIG and subproject does this fall under in sigs.yaml

this is a new subproject for sig-service-catalog called minibroker. Previously it was a personal project maintained by a sevice-catalog contribtuor, carolynvs. We want to use it in
our docs and walkthroughs, and she has graciously decided to donate it to us.

Approvals

This was discussed in person, it's really up to @carolynvs

Additional context for request

Again, talk to @carolynvs

[carolynvs]

I would love to have it migrate over to the kubernetes-sigs/minibroker, but I'm not sure who to work with on that. @cblecker sorry to drag you in but I hear helped with moving service-catalog. Would you know who I can chat with to do the migration of the repository?

[nikhita]

👋 Anyone on the GitHub admin team should be able to do it :)

/assign

I would love to have it migrate over to the kubernetes-sigs/minibroker

I'll take this as a lgtm 👍

[nikhita]

Donated repos need to satisfy some requirements. As per these requirements, the following steps need to be done before the migration:

• All contributors need to have the CNCF CLA signed. The following contributors do not have the CLA signed:

  • @mook-as
  • @DanielJonesEB
  • @f0rmiga
    If your name is listed above, could you sign the CNCF CLA so that https://github.com/osbkit/minibroker can be migrated to the Kubernetes project? Instructions for signing the CLA can be found here. :)

• The repo needs the following template files - code-of-conduct.md, CONTRIBUTING.md, OWNERS, SECURITY_CONTACTS to be incorporated into the Kubernetes project.
  @carolynvs or @jberkhahn can either of you add these files to the repo? The template files can be found here - https://github.com/kubernetes/kubernetes-template-project.

• Files in the repo need to have the Kubernetes boilerplate header. Can you also add the boilerplate header to all relevant files?

  • You can find the boilerplate header for different file extensions here - https://github.com/kubernetes/kubernetes/tree/master/hack/boilerplate
  • If you want to setup a verify script, Add script to verify boilerplate header kubernetes-sigs/cluster-api-provider-digitalocean#111 is an example that does this.
  • To automatically update the header across all files, you can also use Script to automatically add licence headers repo-infra#82.

• I ran a FOSSA license scan for the repo and while a few dependencies were flagged, they are false positives, so all's good there. 👍

[nikhita]

Oh also -- @carolynvs, could you add me as an admin to the repo to transfer it? It's okay to do this after all the requirements above have been addressed too. 👍

[carolynvs]

Thanks for the guidance, @nikhita! I've made you admin and will start working on the task list this weekend.

[DanielJonesEB]

@nikhita Thanks for alerting me. I have now signed the CLA.

[mook-as]

I have attached my GitHub account to my existing LF account (which has signed an employer-wide CLA).

[nikhita]

@mook-as Thanks, I can confirm that your CLA has been signed.

@DanielJonesEB Thanks for getting to this so quickly! Unfortunately, the bot still says that you don't have the CLA signed. Could you try again or reach out to Linux Foundation at https://github.com/kubernetes/community/blob/master/CLA.md#troubleshooting? Sorry for the trouble! 🙇‍♀️

[DanielJonesEB]

@nikhita I've signed a Corporate CLA for EngineerBetter Ltd. It's definitely signed (I went through the HelloSign process, documents were emailed, and I can see the PDF in the LF portal), and the commit was made with the same email address I used when setting up the LF stuff.

The support suggestion is to open a ticket, but I'm not sure what I should say other than "I think I've signed a CLA but the bot says I haven't".

Any ideas on how I can debug this further?

[f0rmiga]

@nikhita @carolynvs I've also attached my Github account to the Linux Foundation account. Let me know if everything looks fine. :)

[nikhita]

@DanielJonesEB @f0rmiga Unfortunately the bot says that the CLA isn't signed for both of you. 😞

The support suggestion is to open a ticket, but I'm not sure what I should say other than "I think I've signed a CLA but the bot says I haven't".

Can you open a dummy PR against https://github.com/kubernetes-sigs/contributor-playground? The bot should add a cncf-cla: yes label, but if it adds a cncf-cla: no label instead, linking that PR to the support ticket should be a little helpful.

Apologies for the back and forth on this, the CLA bot isn't open source yet so opening a ticket is the only way to solve things for now.

[DanielJonesEB]

Aha - I'd signed the Corporate CLA on behalf of EngineerBetter Ltd, but I needed to sign up as an employee additionally.

[f0rmiga]

@nikhita Looks like I got it right now. @DanielJonesEB Thanks for pointing it out. :)

[nikhita]

@DanielJonesEB @f0rmiga yay, thank you so much for following up! :)

@carolynvs please ping me here or on slack once the other tasks are done and I'll migrate the repo. ✅

[carolynvs]

@nikhita I have performed all of the tasks, would you please take a look when you have time and migrate the repository?

[nikhita]

Migration done: https://github.com/kubernetes-sigs/minibroker 🎉

Also created kubernetes/community#3813 to update sigs.yaml.

@carolynvs can the netlify webhook be removed? There seems to be no netlify.toml as well.

We also have a process around requesting subproject websites if you want to integrate netlify btw: https://github.com/kubernetes/community/blob/master/github-management/subproject-site-requests.md. :)

[carolynvs]

I'll remove the netlify stuff. I was going to use it then didn't end up getting around to hooking up a website (minibroker.sh).

[nikhita]

@carolynvs 👍

Once kubernetes/community#3813 merges, we can close this issue.

[carolynvs]

@nikhita Thank you SOOOO MUCH for all of your guidance in getting minibroker migrated over. You did so much and made it really easy for me to donate. ❤️ I really appreciate it and am so excited to see minibroker turned into a subproject! squeeeee

[nikhita]

Webhook removed and kubernetes/community#3813 merged.

/close

[k8s-ci-robot]

@nikhita: Closing this issue.

In response to this:

Webhook removed and kubernetes/community#3813 merged.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.