Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub teams for cosi-driver-minio #2647

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Add GitHub teams for cosi-driver-minio #2647

merged 1 commit into from
Apr 16, 2021

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Apr 16, 2021

Ref: #2631

/assign @ameukam

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/storage Categorizes an issue or PR as relevant to SIG Storage. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2021
@nikhita nikhita mentioned this pull request Apr 16, 2021
Closed
@ameukam
Copy link
Member

ameukam commented Apr 16, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 01df791 into kubernetes:main Apr 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 16, 2021
xing-yang
xing-yang reviewed Apr 16, 2021
View reviewed changes
config/kubernetes-sigs/sig-storage/teams.yaml
- saad-ali
- xing-yang
privacy: closed
cosi-driver-minioc-maintainers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "cosi-driver-minioc-maintainers". Should it be "cosi-driver-minio-maintainers"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nikhita

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says "cosi-driver-minioc-maintainers". Should it be "cosi-driver-minio-maintainers"?

oops, yes. created #2654 to fix this

@nikhita nikhita mentioned this pull request Apr 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@xing-yang xing-yang xing-yang left review comments

@msau42 msau42 Awaiting requested review from msau42

Assignees

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhita @k8s-ci-robot @ameukam @xing-yang