Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mzaian to kubespray-maintainers team #4441

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Add mzaian to kubespray-maintainers team #4441

merged 1 commit into from
Sep 26, 2023

Conversation

mzaian
Copy link
Contributor

@mzaian mzaian commented Sep 7, 2023

Add myself to kubespray-maintainers

I'm contributing already to the releases of Kubespray see below: but doesn't have to forge releases & tags.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Sep 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 7, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Sep 7, 2023

Hello @floryut and @yankay

Would you please review the PR :)

@floryut
Copy link
Contributor

floryut commented Sep 7, 2023

All good for me 👍
lgtm

@floryut
Copy link
Contributor

floryut commented Sep 7, 2023

@mzaian The team kubespray-maintainers in org Kubernetes SIGs has an unsorted list of members please fix this though 😄

@mzaian
Copy link
Contributor Author

mzaian commented Sep 7, 2023 •
edited
Loading

@mzaian The team kubespray-maintainers in org Kubernetes SIGs has an unsorted list of members please fix this though 😄

@floryut Needs alphabet order 😄 just fixed it.

@yankay
Copy link
Member

yankay commented Sep 7, 2023

Thanks @mzaian 👍👍👍

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2023
@mzaian
Copy link
Contributor Author

mzaian commented Sep 19, 2023 •
edited
Loading

/ping @fabriziopandini @justinsb

@neolit123
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, neolit123, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 301182d into kubernetes:main Sep 26, 2023
@floryut
Copy link
Contributor

floryut commented Sep 26, 2023

Thank you @neolit123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yankay yankay yankay approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@yankay yankay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mzaian @floryut @yankay @neolit123 @k8s-ci-robot