Skip to content

Conversation

@lmktfy
Copy link
Member

@lmktfy lmktfy commented Apr 16, 2025

Replacing previous GitHub username, @sftim.

Follow up to #5499

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2025
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 16, 2025
@lmktfy
Copy link
Member Author

lmktfy commented Apr 16, 2025

/test all

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2025
@lmktfy lmktfy force-pushed the 20250416_add_lmktfy branch from b49f993 to 88ee716 Compare April 16, 2025 14:15
@lmktfy
Copy link
Member Author

lmktfy commented Apr 16, 2025

/test all

Replacing previous GitHub username, sftim.
@lmktfy lmktfy force-pushed the 20250416_add_lmktfy branch from 88ee716 to 8f20a20 Compare April 16, 2025 14:31
@lmktfy
Copy link
Member Author

lmktfy commented Apr 16, 2025

/test pull-org-test-all

@lmktfy lmktfy marked this pull request as ready for review April 16, 2025 14:52
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2025
@Priyankasaggu11929
Copy link
Member

/approve

/unhold

Please unhold, if ready to merge. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 562bd40 into kubernetes:main Apr 17, 2025
4 checks passed
@Priyankasaggu11929
Copy link
Member

/unhold

Please unhold, if ready to merge. Thanks!

I was supposed to put a hold label, not unhold, but now its merged. XD

Apologies!

@reylejano
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants