Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CL2 prefix to ENABLE_PVS variable, to allow value to be overriden using env variable #1126

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Add CL2 prefix to ENABLE_PVS variable, to allow value to be overriden using env variable #1126

merged 2 commits into from
Mar 19, 2020

Conversation

maniSbindra
Copy link
Contributor

This PR is based on the conversation #1125 (comment). After this change we will be able to override the value of ENABLE_PVS variable. The default value of this variable will be true.

In tests with kubemark cluster we will override this value to false due to issue #803.

Once this is merged we will PR into the test-infra repo to override this value to false for kubemark cluster tests.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @maniSbindra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2020
@k8s-ci-robot k8s-ci-robot requested review from mborsz and oxddr March 18, 2020 09:19
@maniSbindra maniSbindra mentioned this pull request Mar 18, 2020
Merged
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2020
@maniSbindra
Copy link
Contributor Author

/retest

@maniSbindra
Copy link
Contributor Author

Hi @mm4tt, I am not sure why the clusterloader2 test is failing. Could you suggest what I need to do?

@mm4tt
Copy link
Contributor

mm4tt commented Mar 18, 2020

It might be a flake, let's try again

/test pull-perf-tests-clusterloader2

@maniSbindra
Copy link
Contributor Author

/test pull-perf-tests-clusterloader2

@mm4tt
Copy link
Contributor

mm4tt commented Mar 19, 2020

Looks like the density test timed out in presubmit, strange given that this PR is only touching load test.
Let's try one more time

/test pull-perf-tests-clusterloader2

mm4tt added a commit to mm4tt/test-infra that referenced this pull request Mar 19, 2020
@mm4tt
Revert "Enable NodeKiller on ClusterLoader presubmits"
7d95a61 
This reverts commit 53f19ac.

Here is an example of PR when presubmit failed twice due to NK - kubernetes/perf-tests#1126
An example presubmit run https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/perf-tests/1126/pull-perf-tests-clusterloader2/1240479871608557568/
In the above run, NK killed 5 nodes during density which in the end resulted in test timing out after 1h40min.
Here is the last NK log:
```
W0319 05:03:07.667] I0319 05:03:07.667437   12947 nodes.go:121] NodeKiller: Node e2e-1126-62db2-minion-group-sszg removed from killing. Runs pod prometheus-k8s-0
W0319 05:03:07.668] I0319 05:03:07.667536   12947 nodes.go:135] NodeKiller: 94 nodes available, wants to fail 1 nodes
W0319 05:03:07.668] I0319 05:03:07.667547   12947 nodes.go:140] NodeKiller: Node "e2e-1126-62db2-minion-group-ngh6" schedule for failure
W0319 05:03:07.668] I0319 05:03:07.667643   12947 nodes.go:154] NodeKiller: Stopping docker and kubelet on "e2e-1126-62db2-minion-group-ngh6" to simulate failure
```

We should change the logic to not kill the nodes so many times.
@mm4tt mm4tt mentioned this pull request Mar 19, 2020
Merged
@maniSbindra
Copy link
Contributor Author

Thanks @mm4tt, this time it succeeded.

@mm4tt
Copy link
Contributor

mm4tt commented Mar 19, 2020

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maniSbindra, mm4tt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit a4131e1 into kubernetes:master Mar 19, 2020
@maniSbindra maniSbindra deleted the k8s.io/perf-tests/prefix-ENABLE_PVS-variable-with-CL2 branch March 19, 2020 10:54
mm4tt added a commit to mm4tt/test-infra that referenced this pull request Mar 19, 2020
@mm4tt
Revert "Enable NodeKiller on ClusterLoader presubmits"
0529666 
This reverts commit 53f19ac.

Here is an example of PR when presubmit failed twice due to NK - kubernetes/perf-tests#1126
An example presubmit run https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/perf-tests/1126/pull-perf-tests-clusterloader2/1240479871608557568/
In the above run, NK killed 5 nodes during density which in the end resulted in test timing out after 1h40min.
Here is the last NK log:
```
W0319 05:03:07.667] I0319 05:03:07.667437   12947 nodes.go:121] NodeKiller: Node e2e-1126-62db2-minion-group-sszg removed from killing. Runs pod prometheus-k8s-0
W0319 05:03:07.668] I0319 05:03:07.667536   12947 nodes.go:135] NodeKiller: 94 nodes available, wants to fail 1 nodes
W0319 05:03:07.668] I0319 05:03:07.667547   12947 nodes.go:140] NodeKiller: Node "e2e-1126-62db2-minion-group-ngh6" schedule for failure
W0319 05:03:07.668] I0319 05:03:07.667643   12947 nodes.go:154] NodeKiller: Stopping docker and kubelet on "e2e-1126-62db2-minion-group-ngh6" to simulate failure
```

We should change the logic to not kill the nodes so many times.
@maniSbindra maniSbindra mentioned this pull request Mar 20, 2020
Merged
@mm4tt mm4tt mentioned this pull request Mar 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mm4tt mm4tt mm4tt left review comments

@mborsz mborsz Awaiting requested review from mborsz

@oxddr oxddr Awaiting requested review from oxddr

Assignees

@mm4tt mm4tt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maniSbindra @k8s-ci-robot @mm4tt