Cl2 env template params - backport #1263, #1145, #998 & #921 (release-1.16) #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make all env variables starting with CL2_ prefix available in the CL2 template files. It will allow us to leverage the presets mechanism in cl2 templates and use it instead of relying on cumbersome test override files (in some cases). The problem it solves is that sometimes we want to set something for almost all (but not all tests) tests. Currently, the only way to do that is the create an override file and pass it to many test definitions. This is cumbersome for many reasons, e.g. it requires at least 2 PRs (one to perf-test with the override file, second to test-infra).
Without doing it, it's impossible to easily override boolean param via env. E.g. if I do
```
--env=ENABLE_MY_FEATURE=false
```
The `false` will be treated as string and then in the config file the if statement like this:
```
{{if .ENABLE_MY_FEATURE}}
...
{{end}}
```
Will evaluate to true and will be executed, because "false" is non-empty string that evaluates to true :)
This is to fix issues when `1` is parsed as `true`, e.g. failing presubmit in kubernetes#1262
k8s-ci-robot
added
sig/scalability
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #1263, #1145, #998 & #921.
This will facilitate leveraging some of the backported features in perf-tests in the future.
/sig scalability
/cc mm4tt