add count for errors and error timestamps for dnspropagation measurement #3630
Conversation
It will skip the "no such host" error during startup but only record the real errors
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @Tanzp01. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
| klog.V(4).Infof("DNS lookup %s", url) | ||
| if err := lookup(url); err != nil { | ||
| klog.Warningf("DNS lookup error: %v", err) | ||
| if strings.Contains(err.Error(), "no such host") { |
There was a problem hiding this comment.
nit: https://pkg.go.dev/net#DNSError DNSError struct contains isNotFound boolean flag that might be more reliable and convenient than string comparison
There was a problem hiding this comment.
Thanks Marek for the suggestion! I have updated the code to use DNSError.IsNotFound instead.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marqc, mborsz, Tanzp01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Added count for errors and error timestamps for dnspropagation measurement, it will skip the "no such host" error during startup but only record the real errors with timestamp
Also - added timestamp for all the latencies recorded
What type of PR is this?
/kind feature
What this PR does / why we need it:
To add more information of the DNS performance
Special notes for your reviewer:
Tested locally, able to see the latency logs with timestamp