Make CL2 accept multiple master ips. #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/L
wojtek-t
reviewed
May 28, 2019
mm4tt
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/test pull-perf-tests-clusterloader2-kubemark |
wojtek-t
reviewed
May 29, 2019
k8s-ci-robot
added
size/M
|
/assign @mborsz |
mm4tt
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
mm4tt
force-pushed
the
multi-master
branch
2 times, most recently
from
bfe493a to
9f44524
Compare
This change should be no-op, it only changes the CL2 api (flags/envs) to accept multiple values as master ip. The api change should be backward compatible, i.e. if flag/env was set to a single master-ip it will continue to work. Actual changes supporting multi-master clusters will come in separate PRs.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, mm4tt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should be no-op, it only changes the CL2 api (flags/envs) to accept multiple values as the
master ip- both internal and external.The api change should be backward compatible, i.e. if flag/env was set to a single master-ip it will continue to work in exactly the same way.
Actual changes supporting multi-master clusters will come in separate PRs.