Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable secrets and configmaps in load test #767

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Enable secrets and configmaps in load test #767

merged 1 commit into from
Sep 3, 2019

Conversation

mm4tt
Copy link
Contributor

@mm4tt mm4tt commented Sep 2, 2019

This also merges experimental load with the real load test.

The "knob" has been enabled in presubmits in kubernetes/test-infra#14166.

Ref. #704

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2019
@wojtek-t
Copy link
Member

wojtek-t commented Sep 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2019
@mm4tt
Copy link
Contributor Author

mm4tt commented Sep 3, 2019

/retest

@wojtek-t
Copy link
Member

wojtek-t commented Sep 3, 2019

I'm not sure if this was a flake - e.g. these logs from hollow-kubelet:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/perf-tests/767/pull-perf-tests-clusterloader2-kubemark/1168528796492500992/artifacts/e2e-767-0bf8a-minion-group-hghw/kubelet-hollow-node-dp47t.log

@mm4tt mm4tt mentioned this pull request Sep 3, 2019
Merged
@wojtek-t
Copy link
Member

wojtek-t commented Sep 3, 2019

kubernetes/kubernetes#82259 should fix the problem once merged

mm4tt added a commit to mm4tt/perf-tests that referenced this pull request Sep 3, 2019
@mm4tt
Make deployment.yaml ignore .ENABLE_CONFIGMAPS|SECRETS vars
55c812f 
This is to fix presubmits. It will be switched back in kubernetes#767
@mm4tt mm4tt mentioned this pull request Sep 3, 2019
Merged
@wojtek-t
Copy link
Member

wojtek-t commented Sep 3, 2019

/lgtm cancel

@mm4tt - please change start setting configmaps/secrets in deployment.yaml now

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@mm4tt
Enable secrets and configmaps in load test
e8d1aab 
This also merges experimental load with the real load test.

The "knob" has been enabled in presubmits in kubernetes/test-infra#14166.

Ref. kubernetes#704
@mm4tt mm4tt force-pushed the config_maps_secrets branch from 9441f7d to e8d1aab Compare September 3, 2019 12:41
@mm4tt
Copy link
Contributor Author

mm4tt commented Sep 3, 2019

/lgtm cancel

Matt Matejczyk - please change start setting configmaps/secrets in deployment.yaml now

Done.

@wojtek-t
Copy link
Member

wojtek-t commented Sep 3, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mm4tt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member

wojtek-t commented Sep 3, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 41ba49e into kubernetes:master Sep 3, 2019
@mm4tt mm4tt deleted the config_maps_secrets branch September 4, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysied krzysied Awaiting requested review from krzysied

@oxddr oxddr Awaiting requested review from oxddr

Assignees

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mm4tt @wojtek-t @k8s-ci-robot