-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oci-proxy should redirect per-AWS region #39
Comments
/assign @BenTheElder @jaypipes /sig k8s-infra |
Why 2 percentages for the same region ? |
@hh typo. |
how did we go from 6.5% to 11.12% or 20%? #20 (comment) |
It's the denominator that chaged: |
80/20 Work out exactly. |
lol |
@hh @Riaankl @BenTheElder OK, my advice is just disregard for now the IPs that are assigned with an ASN known to be an Amazon ASN that do not appear in the ip-ranges.json file. I don't know where those are coming from but let's just deal with the ones in ip-ranges.json that we see more than, say, 2% of total container image pulls coming from. So, disregarding those non-ip-range.json IPs, we get this:
which adds up to 90.92% by my count, which is more than acceptable to start with IMHO. |
This AWS ASN Data is generated via https://github.com/kubernetes/k8s.io/blob/main/images/public-log-asn-matcher/README.md Primary data sources include https://bgp.potaroo.net/cidr/autnums.html This is the data that helped us generate usage based on company, and resulting in k8s.io/meta/asns/amazon.yaml If those aren't Amazon ASNs let's fix that. |
I agree @jaypipes |
Initial sources for ASN research kubernetes/k8s.io#1834 (comment) |
[I have been actively continuing development on this] |
Please, let's not editorialize this. To be clear:
|
@BenTheElder Agreed! @hh @calebamiles @Riaankl Please see above |
#42 implements a library to ~efficiently perform "given an IP, determine the AWS region" #47 (WIP) implements the rest:
|
We should close this after rolling out #47 to the sandbox, and follow up with standing up buckets for #38 in kubernetes/k8s.io#3568 + kubernetes/k8s.io#3620 + kubernetes-sigs/promo-tools#533 |
Here are the regions (and ASNs) we need to oci-proxy to actively redirect.
@ameukam is creating the AWS infra in kubernetes/k8s.io#3568.
If we treat Amazon ASNs not in ip-ranges.json as a type of region, then it’s #4 at 11.12% of Amazons total:
=====^^Roughly ~80%^^=====
The text was updated successfully, but these errors were encountered: