-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNI cosmetics #113
Comments
cc @kubernetes/sig-cluster-lifecycle I think About naming, |
I think Secondly, it would be nice to make a search tree (overrideable by --cni-bin-dir) to meet these requirements. No decent RPM/DEB packager wants to use /opt these days. /usr/lib/$PKGNAME/cni/ or /usr/libexec/$PKGNAME are both okay paths for me. /etc/cni/bin I would -1 because there should be nothing except configuration files in /etc. |
Issues go stale after 30d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
/remove-lifecycle rotten |
@errordeveloper @mattymo is this still relevant issue? can we please close the issue otherwise? |
I think it relevant.
…On Tue, 23 Oct 2018, 4:10 pm Davanum Srinivas, ***@***.***> wrote:
@errordeveloper <https://github.com/errordeveloper> @mattymo
<https://github.com/mattymo> is this still relevant issue? can we please
close the issue otherwise?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#113 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPWS-jPL7pZpXqSgCt7MK9anc7VFbfyks5unzFWgaJpZM4KDm3H>
.
|
/help |
@justaugustus: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing as I agree with @BenTheElder's assessment in #862. We're planning on moving the CNI plugins into the kubelet package. /close |
@justaugustus: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Paths
We've had to put CNI bits in
/opt
, as there was no way to tell kubelet to look in other places. As of kubernetes/kubernetes#32151 (already in 1.4), we can pass--cni-bin-dir=
as well as--cni-conf-dir=
to kubelet. I makes sense to put the plugins into/usr/lib/cni
or/usr/lib/kubelet/cni/bin
or/usr/libexec/cni
- anything other then/opt
is good. The reason for this is that traditionally/opt
is used for installing ad-hoc pieces, not for things installed by the package manager. We could also move/etc/cni
to/etc/kubernets/cni
, so we have everything in one directory.Package name
I seems like
kuberentes-cni
would be something user has to lookup, calling itkubernetes-cni-basic-network-plugins
(or justkubernetes-basic-network-plugins
) would make it more obvious. Word "basic" (or "vanilla" or "generic" or something similar) is also good, so we don't give user the impression that they'll have all the plugins.The text was updated successfully, but these errors were encountered: