Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[krel] Add krel anago subcommand to check prerequisites #1739

Closed
markjacksonfishing opened this issue Nov 15, 2020 · 3 comments · Fixed by #1764
Closed

[krel] Add krel anago subcommand to check prerequisites #1739

markjacksonfishing opened this issue Nov 15, 2020 · 3 comments · Fixed by #1764
Assignees
@markjacksonfishing
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@markjacksonfishing
Copy link

As noted in #1673, add krel anago subcommand to check Prerequisites
@markjacksonfishing markjacksonfishing added area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 15, 2020
@markjacksonfishing
Copy link
Author

/assign @markyjackson-taulia
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Nov 15, 2020
@markjacksonfishing markjacksonfishing changed the title [krel] Add krel anago subcommand to check Prerequisites [krel] Add krel anago subcommand to check prerequisites Nov 15, 2020
@saschagrunert
Copy link
Member

Hey @markyjackson-taulia, I think you can directly integrate the functionality into the new structure (krel stage/release), like:

release/pkg/anago/stage.go

Line 245 in b4ca2f6

func (d *DefaultStage) CheckPrerequisites() error { return nil }

release/pkg/anago/release.go

Line 243 in b4ca2f6

func (d *DefaultRelease) CheckPrerequisites() error { return nil }

@markjacksonfishing
Copy link
Author

@saschagrunert awesome! I will have this completed by end of my day US west last time.

@saschagrunert saschagrunert mentioned this issue Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markjacksonfishing markjacksonfishing

Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add prerequisites check to krel stage/release
3 participants
@saschagrunert @markjacksonfishing @k8s-ci-robot