Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prerequisites check to krel stage/release #1764

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Add prerequisites check to krel stage/release #1764

merged 1 commit into from
Nov 20, 2020

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds the necessary environment checks for krel stage/release.

Which issue(s) this PR fixes:

Refers to #1673
Closes #1739

Special notes for your reviewer:

@markyjackson-taulia mentioned to me that it's not possible any more to work on this, so I'll take it over 😇

Does this PR introduce a user-facing change?

Add prerequisites check to `krel stage/release`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2020
@saschagrunert
Add prerequisites check to krel stage/release
f5c24fb 
This adds the necessary environment checks for `krel stage/release`.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

Manual test ✔️

Stage beta:
https://console.cloud.google.com/cloud-build/builds/1ff06e32-8a1a-47d6-a4cd-c586bd9a3697?project=kubernetes-release-test

…
Step #2: INFO Checking prerequisites                        step=2/9
Step #2: INFO Verifying that the commands docker, jq, gsutil, gcloud, ssh commands exist in $PATH. 
Step #2: INFO Verifying minimum Docker version 18.06.0     
Step #2: INFO Verifying Google Cloud access                
Step #2: INFO Verifying that GITHUB_TOKEN environemt variable is set 
…

@saschagrunert saschagrunert mentioned this pull request Nov 20, 2020
Merged
hasheddan
hasheddan approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 47ba8aa into kubernetes:master Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 20, 2020
@saschagrunert saschagrunert deleted the prerequisites branch November 20, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

[krel] Add krel anago subcommand to check prerequisites
3 participants
@saschagrunert @k8s-ci-robot @hasheddan