Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove anago #1765

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Remove anago #1765

merged 1 commit into from
Nov 25, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 20, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is the patch everyone is waiting for! ❤️ We finally remove anago as well as all referencing scripts and documentation to it.

Which issue(s) this PR fixes:

Closes #1673

Special notes for your reviewer:

Requires #1763, #1764, #1769 as well as #1789
Requires manual testing, too.

/hold

Does this PR introduce a user-facing change?

Removed `anago` and all referencing dependencies, for example the `krel anago …` and the `krel gcbmgr` subcommands.

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 20, 2020 •
edited
Loading

Manual testing

@puerco
Copy link
Member

puerco commented Nov 20, 2020

😮 omg. The day has come.

@justaugustus
Copy link
Member

OMGOMGOMG

@puerco puerco mentioned this pull request Nov 21, 2020
Merged
This was referenced Nov 23, 2020
Merged
Merged
@saschagrunert saschagrunert changed the title WIP: Remove anago Remove anago Nov 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2020
@xmudrii
Copy link
Member

xmudrii commented Nov 25, 2020 •
edited
Loading

Manual testing

@saschagrunert
Remove anago
5f9336c 
This is the patch everyone is waiting for! We finally remove `anago` as
well as all referencing scripts and documentation to it.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert
Copy link
Member Author

Everything looks good…
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
xmudrii
xmudrii approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

🚀

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2020
@puerco
Copy link
Member

puerco commented Nov 25, 2020

/lgtm !!

🚀 🚀 🚀

hasheddan
hasheddan approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @saschagrunert and others :)

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, puerco, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hasheddan,puerco,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Nov 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit d1fdfdc into kubernetes:master Nov 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 25, 2020
@saschagrunert saschagrunert deleted the anago branch November 25, 2020 17:54
@justaugustus justaugustus mentioned this pull request Feb 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@xmudrii xmudrii xmudrii approved these changes

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@xmudrii xmudrii

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

[krel] Implement krel stage/release
6 participants
@saschagrunert @k8s-ci-robot @puerco @justaugustus @xmudrii @hasheddan