Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark anago krel migration KEP as implemented #2163

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Mark anago krel migration KEP as implemented #2163

merged 1 commit into from
Dec 4, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 23, 2020 •
edited
Loading

With the merge of the anago removal PR we can now consider that KEP as
done.

cc @kubernetes/release-engineering @kubernetes/sig-release-leads

/hold
Requires kubernetes/release#1765

@saschagrunert
Mark anago krel migration KEP as implemented
94129a0 
With the merge of the anago removal PR we can now consider that KEP as
done.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2020
saschagrunert
saschagrunert commented Nov 23, 2020
View reviewed changes
keps/sig-release/0000-anago-to-krel-migration/kep.yaml
@@ -7,4 +7,5 @@ reviewers:
approvers:
- "@justaugustus"
creation-date: 2020-09-22
status: implementable
latest-milestone: v1.20
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The KEP has still number 0000, which one do we want to assign them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next incremental would be 1735, do the numbers have any special meaning?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I thought they were related to the issue number, but unfortunately we have no corresponding issue.

@saschagrunert
Copy link
Member Author

/hold cancel
This is finished until kubernetes/release#1765 merges.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@saschagrunert
Copy link
Member Author

Ready to be merged 🚀

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4c17a18 into kubernetes:master Dec 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 4, 2020
@saschagrunert saschagrunert deleted the implemented branch December 4, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco puerco left review comments

@alejandrox1 alejandrox1 Awaiting requested review from alejandrox1

@tpepper tpepper Awaiting requested review from tpepper

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @justaugustus @k8s-ci-robot @puerco