Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krel: integrate release archiver #1769

Merged
merged 1 commit into from
Nov 25, 2020
Merged

krel: integrate release archiver #1769

merged 1 commit into from
Nov 25, 2020

Conversation

puerco
Copy link
Member

@puerco puerco commented Nov 22, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR integrates the new release archiver into krel release.

Which issue(s) this PR fixes:

Part of #1673

Depends on #1768

Special notes for your reviewer:

Tested and ready 🚀

Does this PR introduce a user-facing change?

- Integrate the release archiver into `krel release`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Nov 22, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2020
@puerco puerco mentioned this pull request Nov 22, 2020
Closed
18 tasks
puerco
puerco commented Nov 22, 2020
View reviewed changes
pkg/anago/release.go Outdated Show resolved Hide resolved
saschagrunert
saschagrunert reviewed Nov 23, 2020
View reviewed changes
pkg/anago/release.go Outdated Show resolved Hide resolved
@puerco puerco force-pushed the krel-integrate-archiver branch from 38ffb1d to 5c5e51d Compare November 23, 2020 21:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 23, 2020
@puerco
Copy link
Member Author

puerco commented Nov 23, 2020

/test pull-release-cluster-up

@puerco puerco force-pushed the krel-integrate-archiver branch from 5c5e51d to 9fbcafb Compare November 24, 2020 02:43
saschagrunert
saschagrunert approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2020
@saschagrunert
Copy link
Member

@puerco feel free to change the PR title to remove the WIP to let this change get merged.

@puerco puerco force-pushed the krel-integrate-archiver branch from 9fbcafb to 817cd40 Compare November 24, 2020 20:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2020
@puerco
Copy link
Member Author

puerco commented Nov 24, 2020 •
edited
Loading

Test Runs:

✔️ Stage: https://console.cloud.google.com/cloud-build/builds/4f7bf2d1-57a5-4c6d-b65b-57fb4c4d8e0c?project=kubernetes-release-test
✔️ Release: https://console.cloud.google.com/cloud-build/builds/f6409766-801b-4536-b116-647558b46284?project=kubernetes-release-test

New run with log copy at the end of archival process:
✔️ https://console.cloud.google.com/cloud-build/builds/13795203-edc5-4989-be87-26476f16fced?&project=kubernetes-release-test

@puerco
Copy link
Member Author

puerco commented Nov 24, 2020

Rebased to let #1782 into my branch.

@puerco puerco force-pushed the krel-integrate-archiver branch from 817cd40 to e8b504f Compare November 24, 2020 20:39
saschagrunert
saschagrunert reviewed Nov 24, 2020
View reviewed changes
pkg/anago/release.go Outdated Show resolved Hide resolved
@saschagrunert saschagrunert mentioned this pull request Nov 24, 2020
Merged
@puerco
Integrate release archiver with krel anago
f47c1ab 
Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@puerco puerco force-pushed the krel-integrate-archiver branch from e8b504f to f47c1ab Compare November 25, 2020 01:19
@puerco
Copy link
Member Author

puerco commented Nov 25, 2020 •
edited
Loading

Test Runs, Round 2

✔️ (Clean) Release test run with nits, log transfer at the end and rsync instead of copy: https://console.cloud.google.com/cloud-build/builds/037eb543-55ad-4070-8b33-6eee998c13e4?project=kubernetes-release-test
✔️ Second release test run with rsync to bucket: https://console.cloud.google.com/cloud-build/builds/6345aeb0-c9c6-4367-9af3-b93a95a96f3d?project=kubernetes-release-test

@puerco puerco changed the title [WIP] krel: integrate release archiver krel: integrate release archiver Nov 25, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2020
saschagrunert
saschagrunert approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 86702bc into kubernetes:master Nov 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 25, 2020
@puerco puerco deleted the krel-integrate-archiver branch November 27, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@puerco @saschagrunert @k8s-ci-robot