Release Archiver #1768
Merged
Release Archiver #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/release
Two functions have been added to the util pkg: - StripControlCharacters() Removes control chars and bare linefeeds - StripSensitiveData() Removes data deemed sensitive (currently oauth tokens) - CleanLogFile() uses the former two to clean log files Thegcs package now can delete location from a bucket using a new func: - gcs.DeletePath() - this function honors the flag mechanism in the package Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
This commit packs pkg/release/archive.go which implements the old archive functionality from bash anago. Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
This commit adds the tests for the release archiver They are broken into three files: - archive_test.go Implements the test using the counterfeiter mocks - archive_unit_test.go Has te individual unit tests for the functions that power the archiver - releasefakes/fake_archiver_impl.go The generated mock implementation Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
puerco
force-pushed
the
archive-release
branch
from
01dbde3 to
3cf7f6e
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
This was referenced Nov 22, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR implements in go the
anagocode corresponding to the oldarchive_release ()function.This part of the release process copies a release to the release bucket, sanitizes the log files, changes the ACL of the logs and removes older staged releases.
Which issue(s) this PR fixes:
Part of #1673
Related to #1765
Special notes for your reviewer:
PR is broken in 3 commits:
Does this PR introduce a user-facing change?