Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find files and directories when pushing binaries to GCS #1228

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

hasheddan
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This corrects a change that caused only files to be
pushed to GCS, which resulted in binaries in
directories such as /bin to be omitted.

This is currently causing tests, like those dependent on kubeadm to fail.

Which issue(s) this PR fixes:

Fixes #1227

Special notes for your reviewer:

@justaugustus I have tested this locally by comparing the outputs of the previous command and the command in this PR, but have not run a full mock. I could use some assistance if possible :)

Does this PR introduce a user-facing change?

NONE

This corrects a change that caused only files to be
pushed to GCS, which resulted in binaries in
directories such as /bin to be omitted.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

@hasheddan: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 2, 2020
@hasheddan
Copy link
Contributor Author

/cc @justaugustus @tpepper @neolit123

@neolit123
Copy link
Member

thanks for the quick fix. LGTM.

@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Apr 2, 2020
@justaugustus
Copy link
Member

Thanks @hasheddan!
/lgtm
/approve
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Apr 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2614864 into kubernetes:master Apr 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopped publishing /bin folders of CI builds
4 participants