-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find files and directories when pushing binaries to GCS #1228
Conversation
This corrects a change that caused only files to be pushed to GCS, which resulted in binaries in directories such as /bin to be omitted. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks for the quick fix. LGTM. |
Thanks @hasheddan! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This corrects a change that caused only files to be
pushed to GCS, which resulted in binaries in
directories such as /bin to be omitted.
This is currently causing tests, like those dependent on
kubeadm
to fail.Which issue(s) this PR fixes:
Fixes #1227
Special notes for your reviewer:
@justaugustus I have tested this locally by comparing the outputs of the previous command and the command in this PR, but have not run a full mock. I could use some assistance if possible :)
Does this PR introduce a user-facing change?