Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDF] anago: Publish container images on K8s Infra (k8s-staging-kubernetes) - take two #1230

Merged
merged 2 commits into from
Jul 21, 2020
Merged

[VDF] anago: Publish container images on K8s Infra (k8s-staging-kubernetes) - take two #1230

merged 2 commits into from
Jul 21, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Apr 3, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This reverts commit b60c168, reversing
changes made to 2614864.

/assign @tpepper @saschagrunert @cpanato @hasheddan
cc: @kubernetes/release-engineering
/priority critical-urgent

Special notes for your reviewer:

Reapplies #1199, which was partially reverted in #1229.

/hold until @listx kicks the cutover again next week

Does this PR introduce a user-facing change?

[VDF] anago: Publish container images on K8s Infra (k8s-staging-kubernetes) - take two

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Apr 3, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2020
hasheddan
hasheddan approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2020
saschagrunert
saschagrunert approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cpanato
cpanato approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2020
@tpepper
Copy link
Member

tpepper commented May 12, 2020

@listx how are things looking for retrying to cutover?

@justaugustus
Copy link
Member Author

@listx how are things looking for retrying to cutover?

From #270 (comment):

Last I chatted w/ @listx ETA is in a few weeks.
They're still working on some stuff on the Google side.

@justaugustus justaugustus force-pushed the vdf branch 2 times, most recently from afe80c4 to 4697e8f Compare June 23, 2020 02:02
@justaugustus
Copy link
Member Author

justaugustus commented Jun 23, 2020 •
edited
Loading

@listx has kicked off the VDF again today, so it's time to move this PR forward.

I'm running some test releases against this PR...
Mock stage: https://console.cloud.google.com/cloud-build/builds/f4facf4e-c580-4e35-9216-b7137713527e?project=648026197307

EDIT: Needed to re-run the mock stage, as the new k8s-cloud-builder image had not yet been built --> https://console.cloud.google.com/cloud-build/builds/6f98c551-6a0a-42b3-8adb-577737e98cb3?project=kubernetes-release-test

@tpepper
Copy link
Member

tpepper commented Jun 24, 2020

(for anybody watching, we're on hold again...)

@justaugustus justaugustus mentioned this pull request Jul 19, 2020
Merged
@justaugustus
Copy link
Member Author

Next VDF attempt is this Monday, 7/20.
This has been rebased but test stages are failing, because the old staging GCB service account needs Storage Admin access over k8s-staging-kubernetes GCR.

I've opened kubernetes/k8s.io#1042 for this.

@justaugustus justaugustus changed the title [VDF] Revert "Merge pull request #1229 from justaugustus/vdf" [VDF] anago: Publish container images on K8s Infra (k8s-staging-kubernetes) - take two Jul 19, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 19, 2020
@justaugustus justaugustus mentioned this pull request Jul 20, 2020
Closed
@justaugustus
Revert "Merge pull request kubernetes#1229 from justaugustus/vdf"
697801f 
This reverts commit b60c168, reversing
changes made to 2614864.
@justaugustus
anago/ensure_registry_acls: Temporarily disable ACL check for VDF
c33a36d 
The existing check is causing issues on the new registry. This
temporarily disables the write check until the vanity domain flip is
successfully complete.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Copy link
Member Author

@kubernetes/release-engineering -- Promotion for a mock stage/release against this PR was proven out in kubernetes/k8s.io#1047.
This needs to merge before we cut today's RC 2.

Squashed, rebased, and ready for approval.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2020
@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jul 21, 2020
@justaugustus justaugustus mentioned this pull request Jul 21, 2020
Closed
7 tasks
saschagrunert
saschagrunert approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4319929 into kubernetes:master Jul 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 21, 2020
@justaugustus justaugustus mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

Assignees

@saschagrunert saschagrunert

@tpepper tpepper

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @tpepper @saschagrunert @cpanato @hasheddan