Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpromo: Initial image building configuration #2231

Merged
merged 2 commits into from
Aug 31, 2021
Merged

kpromo: Initial image building configuration #2231

merged 2 commits into from
Aug 31, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Aug 31, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

kpromo: Initial image building configuration

Signed-off-by: Stephen Augustus foo@auggie.dev

ref:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kpromo: Initial image building configuration

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects label Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 31, 2021
@justaugustus justaugustus changed the title [WIP] kpromo: Initial image building configuration kpromo: Initial image building configuration Aug 31, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
@justaugustus
Copy link
Member Author

/assign @cpanato @saschagrunert @puerco
cc: @kubernetes/release-engineering @ameukam @justaugustus @spiffxp

@ameukam
Copy link
Member

ameukam commented Aug 31, 2021

/lgtm
/hold
For others to review.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
saschagrunert
saschagrunert reviewed Aug 31, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise LGTM

cmd/kpromo/Dockerfile Outdated Show resolved Hide resolved
@justaugustus
kpromo: Initial image building configuration
9cd9661 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@justaugustus
vulndash: Add -trimpath to go build command
ee316a5 
Signed-off-by: Stephen Augustus <foo@auggie.dev>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@justaugustus
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2021
@ameukam
Copy link
Member

ameukam commented Aug 31, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit 96c97b2 into kubernetes:master Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 31, 2021
This was referenced Aug 31, 2021
Merged
Closed
@justaugustus justaugustus mentioned this pull request Sep 8, 2021
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert left review comments

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @ameukam @saschagrunert @puerco @cpanato