Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang: Build 1.19rc1 images #2601

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 7, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • golang: Build 1.19rc1 images

/hold to check if all looks good
/assign @justaugustus @saschagrunert @puerco @Verolop @palnabarun
cc @kubernetes/release-managers

Which issue(s) this PR fixes:

None
xref: #2575

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- golang: Build 1.19rc1 images

Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jul 7, 2022
@k8s-ci-robot k8s-ci-robot requested review from mkorbi and onlydole July 7, 2022 07:54
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2022
@cpanato cpanato mentioned this pull request Jul 7, 2022
40 tasks
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-release-image-kube-cross
/test pull-release-image-releng-ci

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

(retesting in batches; once the next two pass, retest pull-release-image-k8s-ci-builder and pull-release-image-go-runner)

@cpanato
Copy link
Member Author

cpanato commented Jul 7, 2022

/pull-release-image-k8s-ci-builder

@cpanato
Copy link
Member Author

cpanato commented Jul 7, 2022

/test pull-release-image-go-runner

@cpanato
Copy link
Member Author

cpanato commented Jul 7, 2022

/test pull-release-image-k8s-ci-builder

@cpanato
Copy link
Member Author

cpanato commented Jul 7, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1c4e3bd into kubernetes:master Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 7, 2022
@cpanato cpanato deleted the go119rc1 branch July 7, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants