Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build Go 1.19 images #2628

Merged
merged 1 commit into from
Aug 3, 2022
Merged

build Go 1.19 images #2628

merged 1 commit into from
Aug 3, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 3, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • golang: build 1.19 images

Which issue(s) this PR fixes:

Part of #2575

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- golang: build 1.19 images

/assign @saschagrunert @palnabarun @Verolop @ameukam @justaugustus
cc @kubernetes/release-engineering

Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Aug 3, 2022
@cpanato
Copy link
Member Author

cpanato commented Aug 3, 2022

/hold

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 3, 2022
@k8s-ci-robot k8s-ci-robot requested review from mkorbi and onlydole August 3, 2022 07:48
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 3, 2022
@ameukam
Copy link
Member

ameukam commented Aug 3, 2022

/test pull-release-image-go-runner

@cpanato
Copy link
Member Author

cpanato commented Aug 3, 2022

for go-runner

Step #1: error: failed to solve: golang:1.19-bullseye: no match for platform in manifest sha256:072564420b4ecdb4fb7092b8ac8480912aaf14202bc5c964d867246d4047c755: not found

looks like we need to wait a bit more

$ docker manifest inspect golang:1.19-bullseye | grep -e '"architecture"' -e '"os"'
            "architecture": "amd64",
            "os": "linux"
            "architecture": "arm64",
            "os": "linux",
            "architecture": "386",
            "os": "linux"
            "architecture": "s390x",
            "os": "linux"

@cpanato
Copy link
Member Author

cpanato commented Aug 3, 2022

need more

$ docker manifest inspect golang:1.19-bullseye | grep -e '"architecture"' -e '"os"'
            "architecture": "amd64",
            "os": "linux"
            "architecture": "arm64",
            "os": "linux",
            "architecture": "386",
            "os": "linux"
            "architecture": "ppc64le",
            "os": "linux"
            "architecture": "s390x",
            "os": "linux"

@dims
Copy link
Member

dims commented Aug 3, 2022

/retest

@dims
Copy link
Member

dims commented Aug 3, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Aug 3, 2022

We now have all the images needed:
https://hub.docker.com/_/golang?tab=tags&page=1&name=1.19

$ docker manifest inspect golang:1.19 | grep -e '"architecture"' -e '"os"'
            "architecture": "amd64",
            "os": "linux"
            "architecture": "arm",
            "os": "linux",
            "architecture": "arm64",
            "os": "linux",
            "architecture": "386",
            "os": "linux"
            "architecture": "mips64le",
            "os": "linux"
            "architecture": "ppc64le",
            "os": "linux"
            "architecture": "s390x",
            "os": "linux"
            "architecture": "amd64",
            "os": "windows",
            "architecture": "amd64",
            "os": "windows",

@dims
Copy link
Member

dims commented Aug 3, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2022
@dims
Copy link
Member

dims commented Aug 3, 2022

/hold

probably need to wait for the CI jobs to be green :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2022
@dims
Copy link
Member

dims commented Aug 3, 2022

/test pull-release-image-go-runner

@k8s-ci-robot
Copy link
Contributor

@dims: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-release-cluster-up
  • /test pull-release-image-debian-base
  • /test pull-release-image-debian-iptables
  • /test pull-release-image-distroless-iptables
  • /test pull-release-image-go-runner
  • /test pull-release-image-k8s-ci-builder
  • /test pull-release-image-k8s-cloud-builder
  • /test pull-release-image-kube-cross
  • /test pull-release-image-kubepkg
  • /test pull-release-image-releng-ci
  • /test pull-release-image-setcap
  • /test pull-release-integration-test
  • /test pull-release-test
  • /test pull-release-verify

Use /test all to run the following jobs that were automatically triggered:

  • pull-release-image-go-runner
  • pull-release-image-k8s-ci-builder
  • pull-release-image-kube-cross
  • pull-release-image-releng-ci
  • pull-release-integration-test
  • pull-release-test
  • pull-release-verify

In response to this:

/test ull-release-image-go-runner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Aug 3, 2022

pull-release-image-go-runner failed twice. will wait for @palnabarun or @cpanato or @ameukam :)

@puerco
Copy link
Member

puerco commented Aug 3, 2022

/test pull-release-image-go-runner

@puerco
Copy link
Member

puerco commented Aug 3, 2022

I retriggered the job and it worked, I'll try again to check.
/test pull-release-image-go-runner

@puerco
Copy link
Member

puerco commented Aug 3, 2022

I'm trying to investigate why it's flaking I'm going to merge this one to get signal from the 1.19 builder images.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit f9d1361 into kubernetes:master Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 3, 2022
@puerco puerco mentioned this pull request Aug 3, 2022
40 tasks
@cpanato cpanato deleted the go119 branch August 4, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants