Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link to example go-template for release tool #3216

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented Aug 22, 2023

What type of PR is this?

/kind documentation

What this PR does / why we need it:

I was looking into using the release-notes tool in this repo and noticed that the documentation pointed to an example template that has since been moved.

Which issue(s) this PR fixes:

None

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Michael Shen <mishen@umich.edu>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject needs-priority labels Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mjlshen!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mjlshen. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2023
@mjlshen
Copy link
Contributor Author

mjlshen commented Aug 22, 2023

The test got rate-limited

Error:      	Expected nil, but got: &fmt.wrapError{msg:"unable to list GitHub issues for kubernetes/sig-release repo: getting issues from client: fetching issues from repo: GET https://api.github.com/repos/kubernetes/sig-release/issues?per_page=50&state=open: 403 API rate limit exceeded for 18.189.147.8. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 9m15s]", err:(*fmt.wrapError)(0xc003cd53a0)}

/test pull-release-integration-test

@k8s-ci-robot
Copy link
Contributor

@mjlshen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

The test got rate-limited

Error:      	Expected nil, but got: &fmt.wrapError{msg:"unable to list GitHub issues for kubernetes/sig-release repo: getting issues from client: fetching issues from repo: GET https://api.github.com/repos/kubernetes/sig-release/issues?per_page=50&state=open: 403 API rate limit exceeded for 18.189.147.8. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 9m15s]", err:(*fmt.wrapError)(0xc003cd53a0)}

/test pull-release-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

/retest

@saschagrunert
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7cac31e into kubernetes:master Aug 23, 2023
4 checks passed
@mjlshen mjlshen deleted the release-go-template-link branch August 23, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants