build kube-cross, go-runner, releng-ci with golang 1.22.8, 1.23.2 #3779
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/release
|
Hi @haitch. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
haitch
changed the title
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
haitch
force-pushed
the
haitao/golang_patch_oct2024
branch
from
f5df657
to
7e4daf2
Compare
|
/test pull-release-image-go-runner |
|
/test pull-release-image-releng-ci |
|
/test pull-release-image-kube-cross |
2 similar comments
|
/test pull-release-image-kube-cross |
|
/test pull-release-image-kube-cross |
|
Let me look at the failure here more and see if this is legit |
|
we are blocked on build cross image, it seems docker.io/library/golang no longer offer linux/ppc64le linux/s390x arch on bullseye |
|
cc @mkumatag @sudip-ibm @madeelibm for linux/ppc64le linux/s390x arch(es) |
Debian bullseye release recently got EOLed as per the Debian document and into LTS mode. 
What really this means that Debian Long Term Support (LTS) is a project to extend the lifetime of all Debian stable releases to (at least) 5 years. Debian LTS is not handled by the Debian Security and Release teams, but by a separate group of volunteers and companies interested in making it a success. Thus the Debian LTS team takes over security maintenance of the various releases once the Debian Security team stops its work. Important: The current LTS version is Debian 11 ("bullseye") and will be supported until August 31st, 2026. Supported architectures in Debian 11 LTS are limited to amd64, i386, arm64 and armhf. Users of other architectures are especially encouraged to upgrade to Debian 12 (''bookworm''). Considering above information and recommendation, lets stop building the bullseye based image for these unsupported platforms and start consuming the later versions. Thanks. |
| @@ -28,7 +28,7 @@ IMGNAME = kube-cross | |||
| # - v1.100.0-go1.17-bullseye.0 satisfies SemVer regex, while: | |||
There was a problem hiding this comment.
can we remove these arch(linux/ppc64le linux/s390x) entries from here or can we feed the platforms variable to the variants.yaml to build only on the supported platforms.
for testing I have removed these problematic platforms and build went through here - #3782
Background: As far as I know, the artifacts were cross-built, If I’m correct, we don’t need this kube-cross image to be a multi-arch fat manifest except for amd64 (which is the architecture most build systems use) to generate the artifacts. I believe we can safely exclude the problematic architectures while building this image to unblock the process and generate the artifacts smoothly. I’ve made that change here, and the image built fine.
There was a problem hiding this comment.
thanks, I can do that.
shall we wait for this proposal to be commonly agreed on?
There was a problem hiding this comment.
anyway, carried your commit, I guess that PR approve will have to take consideration of that proposal approve.
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold |
|
LGTM |
k8s-ci-robot
added
lgtm
| @@ -53,7 +53,7 @@ export DOCKER_CLI_EXPERIMENTAL=enabled | |||
| # TODO: Support multi-arch kube-cross images for linux/arm | |||
| # Currently some of the components references in the Dockerfile are | |||
| # not supported in specific architectures | |||
| PLATFORMS ?= linux/amd64 linux/arm64 linux/ppc64le linux/s390x #linux/arm | |||
| PLATFORMS ?= linux/amd64 linux/arm64 #linux/arm | |||
There was a problem hiding this comment.
Nit: can we comment those platforms instead, like we did for linux/arm?
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dims, haitch, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold we have the new announcement here: https://groups.google.com/g/kubernetes-sig-release/c/LgxPv6PM4QU/m/SGEv6U_wCQAJ?pli=1 |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Timeout error |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
xref #3778
Special notes for your reviewer:
Does this PR introduce a user-facing change?