Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch on experimental support in docker CLI #617

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Switch on experimental support in docker CLI #617

merged 1 commit into from
Sep 4, 2018

Conversation

dims
Copy link
Member

@dims dims commented Sep 4, 2018

In a70044a, we wanted to use the experimental support for manifest in the docker CLI, but forgot to turn the flag on.

@dims
Switch on experimental support in docker CLI
118ef15 
Change-Id: I559e040b11f9a42f5705dc8c23eeb204cd68c2c2
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2018
tpepper
tpepper approved these changes Sep 4, 2018
View reviewed changes
Copy link
Member

@tpepper tpepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit e9f40b8 into kubernetes:master Sep 4, 2018
calebamiles pushed a commit to calebamiles/release that referenced this pull request Sep 5, 2018
Revert "Merge pull request kubernetes#617 from dims/switch-on-experim…
67b0968 
…ental-support-in-cli"

This reverts commit e9f40b8, reversing
changes made to ff17b75.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpepper tpepper tpepper approved these changes

Assignees

@tpepper tpepper

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dims @k8s-ci-robot @tpepper