Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] deb: Rework debian build tooling #734

Closed
wants to merge 7 commits into from
Closed

[WIP] deb: Rework debian build tooling #734

wants to merge 7 commits into from

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jun 12, 2019 •
edited
Loading

WIP. No review required at the moment.

@justaugustus
debian: Update var/const/func naming
e5c67fa 
Baseline renaming of var/const/func that were either inaccurate
or not concise. This is a first housekeeping with no changes to
program logic.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 12, 2019
@justaugustus
Copy link
Member Author

/milestone v1.16
/priority important-soon
/kind cleanup feature

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 12, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2019
@justaugustus justaugustus force-pushed the build-deb branch 2 times, most recently from 2f05d6a to bd1afee Compare June 13, 2019 14:14
@tpepper tpepper mentioned this pull request Jun 13, 2019
Closed
@justaugustus justaugustus mentioned this pull request Jun 14, 2019
Open
11 tasks
@justaugustus
debian: Restructure directory
3a7d1fe 
Renames the bionic/ dir to packages/ and removes the symlinks for
individual Debian/Ubuntu releases. We've been building with the same
package templates for some time now, which suggests that the symlinks
are extraneous. Additionally, we remove symlinks in the kubeadm
package and bring config files for each package up a few levels.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
debian: Update package install instructions and configs
07712b5 
Here we sync the config files from k/k (build/debs) into the
relevant packages and update the package install instructions to
copy the new config files onto the destination system.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
debian: Move package definitions and CLI tool
cd15b43 
Here we reorganize the directory structure to be more Go-centric.
The CLI tool moves to cmd/k8spkgctl and the package definitions
move to build/debs. We're also pruning the stale vendor folder here.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
deps: Bump blang/semver to v3.6.1 and update vendor
357528d 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
debian: Clean up versioning logic in build tooling
2ea08bc 
- Remove logic that interprets any unsupported Kubernetes version
- Use Kubernetes versions as basis for determining package versions
- Move dependencies to a struct

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
debian: Add new types and refactor package logic
d4aec4a 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
This was referenced Jun 20, 2019
Merged
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

@justaugustus: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

/hold
(until 1.12.10 is released)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2019
@justaugustus justaugustus mentioned this pull request Sep 24, 2019
Merged
@justaugustus
Copy link
Member Author

Will be superseded by a set of smaller PRs, the first of which is here: #884
/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closed this PR.

In response to this:

Will be superseded by a set of smaller PRs, the first of which is here: #884
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

(I'll keep my branch around for reference.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AishSundar AishSundar Awaiting requested review from AishSundar

@claurence claurence Awaiting requested review from claurence

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
2 participants
@justaugustus @k8s-ci-robot