-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] deb: Rework debian build tooling #734
Conversation
Baseline renaming of var/const/func that were either inaccurate or not concise. This is a first housekeeping with no changes to program logic. Signed-off-by: Stephen Augustus <saugustus@vmware.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/milestone v1.16 |
2f05d6a
to
bd1afee
Compare
Renames the bionic/ dir to packages/ and removes the symlinks for individual Debian/Ubuntu releases. We've been building with the same package templates for some time now, which suggests that the symlinks are extraneous. Additionally, we remove symlinks in the kubeadm package and bring config files for each package up a few levels. Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Here we sync the config files from k/k (build/debs) into the relevant packages and update the package install instructions to copy the new config files onto the destination system. Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Here we reorganize the directory structure to be more Go-centric. The CLI tool moves to cmd/k8spkgctl and the package definitions move to build/debs. We're also pruning the stale vendor folder here. Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
- Remove logic that interprets any unsupported Kubernetes version - Use Kubernetes versions as basis for determining package versions - Move dependencies to a struct Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
Will be superseded by a set of smaller PRs, the first of which is here: #884 |
@justaugustus: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(I'll keep my branch around for reference.) |
WIP. No review required at the moment.