-
Notifications
You must be signed in to change notification settings - Fork 526
Add hack/tools.go and "prettify" Dockerfiles #896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a strictly cosmetic change to the Dockerfiles (fixing up spacing) to trigger the post-submit image building/pushing. Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
|
@justaugustus: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
fejta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
(so you can merge when you want)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fejta, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @fejta! |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've made some cosmetic changes to the Dockerfiles in
build/andimages/. Now that kubernetes/test-infra#14735 and kubernetes/test-infra#14711 have landed, this should trigger pushes for the container images to our staging GCP project.This PR also adds a
hack/tools.go, which includes an empty import for thek8s.io/release/build/debssubmodule (to ensure we pull in its' dependencies when someonego gets k/release)./assign @fejta @Katharine @dims @tpepper
cc: @kubernetes/release-engineering
/priority important-soon
/kind cleanup
/milestone v1.17