Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add verify script for go-mod-tidy #245

Merged
merged 1 commit into from
Jan 22, 2022
Merged

add verify script for go-mod-tidy #245

merged 1 commit into from
Jan 22, 2022

Conversation

pravarag
Copy link
Contributor

@pravarag pravarag commented Nov 8, 2021

Fixes: #239

I've added a basic script for checking go mod tidy changes as part of CI jobs.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 8, 2021
@k8s-ci-robot k8s-ci-robot requested review from fejta and Verolop November 8, 2021 11:58
@pravarag pravarag mentioned this pull request Nov 8, 2021
Closed
@palnabarun
Copy link
Member

/cc

@pravarag
Copy link
Contributor Author

@palnabarun @justaugustus do you have any suggestions to improve the changes that I've included in this PR, kindly let me know :)

@pravarag pravarag marked this pull request as ready for review December 5, 2021 14:04
@pravarag pravarag changed the title [WIP] add verify script for go-mod-tidy add verify script for go-mod-tidy Dec 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2021
justaugustus
justaugustus approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pravarag -- This is pretty close to what we have in k/release, so LGTM!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, pravarag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit b719aa1 into kubernetes:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@fejta fejta Awaiting requested review from fejta

@Verolop Verolop Awaiting requested review from Verolop

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go mod tidy diff checks should be a part of CI jobs
4 participants
@pravarag @k8s-ci-robot @palnabarun @justaugustus