Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platforms documentation #1360

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Add platforms documentation #1360

merged 1 commit into from
Jan 27, 2021

Conversation

saschagrunert
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This adds the documentation about supported Kubernetes platforms to our
repository.

Which issue(s) this PR fixes:

Refers to #1337

Special notes for your reviewer:

None

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 30, 2020
hasheddan
hasheddan reviewed Nov 30, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @saschagrunert! Left a few comments below, but mostly looks good to me. Let's allow some others to weigh in as well :)

/hold

release-engineering/platforms.md Outdated Show resolved Hide resolved
release-engineering/platforms.md Outdated
Tier 2 platforms are considered as "guaranteed to build". To achieve this, they
have to fulfil the following criteria:

- **Any** official binary release is provided for the platform. Building the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is kind of tricky because we currently release artifacts that are not well tested or tested at all, but in the future it would be great if we "released" only Tier 1 artifacts, and published Tier 2 separately. However, I think we have to stick with that is defined here for now given our current state.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasheddan do we track this open flanks already?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
hasheddan
hasheddan reviewed Dec 8, 2020
View reviewed changes
release-engineering/platforms.md Outdated
Comment on lines 19 to 24
- **All** official binary releases are provided for the platform. This includes
container images as well as deb and rpm packages. Building the artifacts is
integrated in the release process.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if maybe support levels should be "per-binary". For instance if we thoroughly test kubectl on darwin-amd64 it would technically still fall into Tier 2 by this definition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I changed the doc to outline that we can scope Tiers to single binaries. Let me know what you think.

release-engineering/platforms.md Outdated Show resolved Hide resolved
hasheddan
hasheddan approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert thanks for the update!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2020
tpepper
tpepper suggested changes Dec 11, 2020
View reviewed changes
Copy link
Member

@tpepper tpepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as stated this document can give a reader a wrong impression of what is community support and the overall Kubernetes project's support stance, versus covering what it is that SIG Release does within that broader context. I've suggested a few slight changes in wording which soften what I think reads as overstatements around the term "support".

@saschagrunert
Add platforms documentation
004bd6e 
This adds the documentation about supported Kubernetes platforms to our
repository.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@saschagrunert
Copy link
Member Author

I think as stated this document can give a reader a wrong impression of what is community support and the overall Kubernetes project's support stance, versus covering what it is that SIG Release does within that broader context. I've suggested a few slight changes in wording which soften what I think reads as overstatements around the term "support".

Makes sense, I changed the document as suggested. Please take a look again.

hasheddan
hasheddan approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-adding my LGTM :) thanks again @saschagrunert!

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2021
@hasheddan hasheddan mentioned this pull request Jan 11, 2021
Closed
@saschagrunert saschagrunert mentioned this pull request Jan 18, 2021
Closed
7 tasks
@saschagrunert
Copy link
Member Author

I think we addressed most concerns and we can lift the hold.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8446cbc into kubernetes:master Jan 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpepper tpepper tpepper requested changes

@hasheddan hasheddan hasheddan approved these changes

@mkorbi mkorbi Awaiting requested review from mkorbi

@puerco puerco Awaiting requested review from puerco

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@saschagrunert @k8s-ci-robot @tpepper @mkorbi @hasheddan