Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine tier 3 platform support definition #1444

Merged
merged 1 commit into from
Feb 1, 2021

Conversation

hasheddan
Copy link
Contributor

What type of PR is this:

/kind documentation

What this PR does / why we need it:

Updates tier 3 platform support definition to require demonstrated
ability to target the platform and documentation available for doing so.

Signed-off-by: hasheddan georgedanielmangum@gmail.com

Which issue(s) this PR fixes:

xref #1337

Special notes for your reviewer:

Updates based on feedback in SIG Arch meeting.

/assign @saschagrunert @justaugustus
/cc @dims

Updates tier 3 platform support definition to require demonstrated
ability to target the platform and documentation available for doing so.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jan 31, 2021
@k8s-ci-robot k8s-ci-robot requested a review from dims January 31, 2021 22:56
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2021

- Official builds are not available.
- Automated testing is not setup.
- Documentation on how to build for the platform is available.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am trying to decide if this documentation belongs in sig-release/release-engineering or in https://github.com/kubernetes/community/tree/master/contributors/devel/sig-architecture. I would like to keep as much of this information located together as possible, but we already have the beginning of guide in k/community. Ultimately, it seems like this primarily falls under release-engineering in terms of shepherding people through the process, and we also need to make sure release-engineering has knowledge of how to build all platforms, so I am somewhat inclined to move the guide here, point folks to it, and have Tier 3 build docs also live here.

Thoughts? @dims @saschagrunert

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release-engineering sounds good to me!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should live here.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm


- Official builds are not available.
- Automated testing is not setup.
- Documentation on how to build for the platform is available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this should live here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants