Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release notes text in map files #2589

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

rayandas
Copy link
Member

@rayandas rayandas commented Aug 7, 2024

What type of PR is this:

/kind cleanup

What this PR does / why we need it:

This PR fixes the syntax error in map yaml files since krel was throwing error while trying to create release notes draft PR for v1.31.0-rc.1.

FATA creating Draft PR: while running release notes fix flow: while getting map for PR #125828: while reading release notes maps: while parsing note map in /var/folders/8s/8mhcz0cx1_7g258xfrl991m00000gq/T/k8s-4068473374/releases/release-1.31/release-notes/maps/pr-125163-map.yaml: decoding note map: yaml: line 2: did not find expected key  file="cmd/root.go:59"

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 7, 2024
Copy link

linux-foundation-easycla bot commented Aug 7, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rayandas / name: Rayan Das (e7267e0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 7, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2024
Signed-off-by: Rayan Das <rayandas91@gmail.com>
@rayandas rayandas force-pushed the fix-release-notes branch from 2c3a2c3 to e7267e0 Compare August 7, 2024 18:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@Priyankasaggu11929
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npolshakova, Priyankasaggu11929, rayandas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 719542c into kubernetes:master Aug 8, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Aug 8, 2024
@neoaggelos
Copy link
Contributor

late /lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants