Removes reference to "cherry-pick candidate" label, which is no longe… #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XS
nikhita
reviewed
Oct 17, 2018
release-team/README.md
Outdated
| - Mark your PR with the milestone corresponding to the release you want to port back to (e.g. `v1.5`), and add the `cherrypick-candidate` label to it | ||
| - The Patch Release Manager will then review the PR and if it is ok for cherry-picking, will apply a `cherrypick-approved` label to it | ||
| - Once your PR has been marked with the `cherrypick-approved` label by the Patch Release Manager, you should prepare a cherry-pick to the requested branch following the instructions [here](https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md#how-do-cherrypick-candidates-make-it-to-the-release-branch) | ||
| - Follow the [cherry-pick instructions to open a cherry-pick PR.](https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md |
There was a problem hiding this comment.
gahhhh too many git stashes
INSTA RESPONSE
There was a problem hiding this comment.
still needs a closing bracket at the end lol
k8s-ci-robot
added
size/M
|
Apologies - found more outdated references. 😬 |
AishSundar
reviewed
Oct 18, 2018
release-team/README.md
Outdated
| - Mark your PR with the milestone corresponding to the release you want to port back to (e.g. `v1.5`), and add the `cherrypick-candidate` label to it | ||
| - The Patch Release Manager will then review the PR and if it is ok for cherry-picking, will apply a `cherrypick-approved` label to it | ||
| - Once your PR has been marked with the `cherrypick-approved` label by the Patch Release Manager, you should prepare a cherry-pick to the requested branch following the instructions [here](https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md#how-do-cherrypick-candidates-make-it-to-the-release-branch) | ||
| - Follow the [cherry-pick instructions to open a cherry-pick PR.](https://git.k8s.io/community/contributors/devel/cherry-picks.md |
|
Thanks @guineveresaenger. Just 1 nit. Feel free to remove hold after fixing that. /lgtm |
k8s-ci-robot
added
do-not-merge/hold
guineveresaenger
force-pushed
the
cherry-pick
branch
from
6d91dac to
aeb0b2d
Compare
k8s-ci-robot
removed
the
lgtm
|
/remove hold Fixed missing paren. 🤦♀️ |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AishSundar, guineveresaenger, mrbobbytables, nikopen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Assuming you meant to remove the hold :) /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r used