Remove the must be closed requirement in CVE feed #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `official-cve-feed` label is sufficient in filtering down to valid issues.
k8s-ci-robot
added
sig/security
k8s-ci-robot
added
the
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
This has been a feature request that was made earlier here: #97 We discussed this in the SIG Security call too today, and there were no concerns raised. Only note I will make is we need to add a status field as a next step in the CVE feed /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, PushkarJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
official-cve-feedlabel is sufficient in filtering down to valid issues.@kubernetes/security-response-committee @kubernetes/sig-security-pr-reviews @PushkarJ
For example, currently kubernetes/kubernetes#121879 is open and published to mitre but not included in the CVE feed which seems like the wrong approach. We do not add the
official-cve-feedlabel until we fill out the issue details, so I do not think there is any need to wait until the issue is closed before including it in the feed.