Generate a schema for the ProwJob crd (#19522)

* Add CRD generation

* Update tektoncd to a version with json tags

* Broken CRD

* Add marker

* Update controller-runtime to latest head

* Use generated crd in integation tests

* Remove incorrect third copy of crd

* SSA can not default the port?

* Protocols for everyone

* Remove go 1.17 header

* Link the crd instead of duplicating it

* Update getting started docs

* Remove stale copyfiles

* Re-Add validation that completionTime must be set

* Apply ProwJob crd with --server-side=true

* Add announcement and schemaless manifest as fallback

* Args is a list

* Must specify protocol

config/prow/cluster/BUILD.bazel

@@ -73,7 +73,11 @@ release(
     component("prow-canary-k8s-io", "managedcertificate"),
     component("prow-k8s-io", "managedcertificate"),
     component("prow-kubernetes-io", "managedcertificate"),
-    component("prowjob", "customresourcedefinition"),
+    component(
+        "prowjob",
+        "customresourcedefinition",
+        args = ["--server-side=true"],
+    ),
     component("pushgateway", "deployment"),
     component("sinker", "service", "deployment", "rbac"),
     component("statusreconciler", "deployment", "rbac"),

config/prow/cluster/crier_service.yaml

@@ -9,5 +9,6 @@ spec:
   ports:
     - name: metrics
       port: 9090
+      protocol: TCP
   selector:
     app: crier

config/prow/cluster/deck_service.yaml

@@ -26,6 +26,8 @@ spec:
   - name: main
     port: 80
     targetPort: 8080
+    protocol: TCP
   - name: metrics
     port: 9090
+    protocol: TCP
   type: NodePort

config/prow/cluster/hook_service.yaml

@@ -25,6 +25,8 @@ spec:
   ports:
   - name: main
     port: 8888
+    protocol: TCP
   - name: metrics
     port: 9090
+    protocol: TCP
   type: NodePort

config/prow/cluster/horologium_service.yaml

@@ -9,5 +9,6 @@ spec:
   ports:
     - name: metrics
       port: 9090
+      protocol: TCP
   selector:
     app: horologium

config/prow/cluster/prow_controller_manager_service.yaml

@@ -23,5 +23,6 @@ spec:
   ports:
     - name: metrics
       port: 9090
+      protocol: TCP
   selector:
     app: prow-controller-manager

config/prow/cluster/prowjob_customresourcedefinition_schemaless.yaml

@@ -0,0 +1,95 @@
+apiVersion: apiextensions.k8s.io/v1
+kind: CustomResourceDefinition
+metadata:
+  name: prowjobs.prow.k8s.io
+  annotations:
+    "api-approved.kubernetes.io": "https://github.com/kubernetes/test-infra/pull/8669"
+spec:
+  group: prow.k8s.io
+  names:
+    kind: ProwJob
+    singular: prowjob
+    plural: prowjobs
+  scope: Namespaced
+  versions:
+  - name: v1
+    served: true
+    storage: true
+    schema:
+      openAPIV3Schema:
+        type: object
+        properties:
+          spec:
+            type: object
+            x-kubernetes-preserve-unknown-fields: true
+            properties:
+              max_concurrency:
+                type: integer
+                minimum: 0
+              type:
+                type: string
+                enum:
+                - "presubmit"
+                - "postsubmit"
+                - "periodic"
+                - "batch"
+          status:
+            type: object
+            x-kubernetes-preserve-unknown-fields: true
+            properties:
+              state:
+                type: string
+                enum:
+                - "triggered"
+                - "pending"
+                - "success"
+                - "failure"
+                - "aborted"
+                - "error"
+            anyOf:
+            - not:
+                properties:
+                  state:
+                    enum:
+                    - "success"
+                    - "failure"
+                    - "error"
+            - required:
+              - completionTime
+    additionalPrinterColumns:
+    - name: Job
+      type: string
+      description: The name of the job being run.
+      jsonPath: .spec.job
+    - name: BuildId
+      type: string
+      description: The ID of the job being run.
+      jsonPath: .status.build_id
+    - name: Type
+      type: string
+      description: The type of job being run.
+      jsonPath: .spec.type
+    - name: Org
+      type: string
+      description: The org for which the job is running.
+      jsonPath: .spec.refs.org
+    - name: Repo
+      type: string
+      description: The repo for which the job is running.
+      jsonPath: .spec.refs.repo
+    - name: Pulls
+      type: string
+      description: The pulls for which the job is running.
+      jsonPath: ".spec.refs.pulls[*].number"
+    - name: StartTime
+      type: date
+      description: When the job started running.
+      jsonPath: .status.startTime
+    - name: CompletionTime
+      type: date
+      description: When the job finished running.
+      jsonPath: .status.completionTime
+    - name: State
+      description: The state of the job.
+      type: string
+      jsonPath: .status.state

config/prow/cluster/starter-gcs.yaml

@@ -127,102 +127,6 @@ data:
         - image: alpine
           command: ["/bin/date"]
 ---
-apiVersion: apiextensions.k8s.io/v1
-kind: CustomResourceDefinition
-metadata:
-  name: prowjobs.prow.k8s.io
-  annotations:
-    "api-approved.kubernetes.io": "https://github.com/kubernetes/test-infra/pull/8669"
-spec:
-  group: prow.k8s.io
-  names:
-    kind: ProwJob
-    singular: prowjob
-    plural: prowjobs
-  scope: Namespaced
-  versions:
-  - name: v1
-    served: true
-    storage: true
-    schema:
-      openAPIV3Schema:
-        type: object
-        properties:
-          spec:
-            type: object
-            x-kubernetes-preserve-unknown-fields: true
-            properties:
-              max_concurrency:
-                type: integer
-                minimum: 0
-              type:
-                type: string
-                enum:
-                - "presubmit"
-                - "postsubmit"
-                - "periodic"
-                - "batch"
-          status:
-            type: object
-            x-kubernetes-preserve-unknown-fields: true
-            properties:
-              state:
-                type: string
-                enum:
-                - "triggered"
-                - "pending"
-                - "success"
-                - "failure"
-                - "aborted"
-                - "error"
-            anyOf:
-            - not:
-                properties:
-                  state:
-                    enum:
-                    - "success"
-                    - "failure"
-                    - "error"
-            - required:
-              - completionTime
-    additionalPrinterColumns:
-    - name: Job
-      type: string
-      description: The name of the job being run.
-      jsonPath: .spec.job
-    - name: BuildId
-      type: string
-      description: The ID of the job being run.
-      jsonPath: .status.build_id
-    - name: Type
-      type: string
-      description: The type of job being run.
-      jsonPath: .spec.type
-    - name: Org
-      type: string
-      description: The org for which the job is running.
-      jsonPath: .spec.refs.org
-    - name: Repo
-      type: string
-      description: The repo for which the job is running.
-      jsonPath: .spec.refs.repo
-    - name: Pulls
-      type: string
-      description: The pulls for which the job is running.
-      jsonPath: ".spec.refs.pulls[*].number"
-    - name: StartTime
-      type: date
-      description: When the job started running.
-      jsonPath: .status.startTime
-    - name: CompletionTime
-      type: date
-      description: When the job finished running.
-      jsonPath: .status.completionTime
-    - name: State
-      description: The state of the job.
-      type: string
-      jsonPath: .status.state
----
 apiVersion: apps/v1
 kind: Deployment
 metadata:

config/prow/cluster/starter-s3.yaml

@@ -127,102 +127,6 @@ data:
         - image: alpine
           command: ["/bin/date"]
 ---
-apiVersion: apiextensions.k8s.io/v1
-kind: CustomResourceDefinition
-metadata:
-  name: prowjobs.prow.k8s.io
-  annotations:
-    "api-approved.kubernetes.io": "https://github.com/kubernetes/test-infra/pull/8669"
-spec:
-  group: prow.k8s.io
-  names:
-    kind: ProwJob
-    singular: prowjob
-    plural: prowjobs
-  scope: Namespaced
-  versions:
-  - name: v1
-    served: true
-    storage: true
-    schema:
-      openAPIV3Schema:
-        type: object
-        properties:
-          spec:
-            type: object
-            x-kubernetes-preserve-unknown-fields: true
-            properties:
-              max_concurrency:
-                type: integer
-                minimum: 0
-              type:
-                type: string
-                enum:
-                - "presubmit"
-                - "postsubmit"
-                - "periodic"
-                - "batch"
-          status:
-            type: object
-            x-kubernetes-preserve-unknown-fields: true
-            properties:
-              state:
-                type: string
-                enum:
-                - "triggered"
-                - "pending"
-                - "success"
-                - "failure"
-                - "aborted"
-                - "error"
-            anyOf:
-            - not:
-                properties:
-                  state:
-                    enum:
-                    - "success"
-                    - "failure"
-                    - "error"
-            - required:
-              - completionTime
-    additionalPrinterColumns:
-    - name: Job
-      type: string
-      description: The name of the job being run.
-      jsonPath: .spec.job
-    - name: BuildId
-      type: string
-      description: The ID of the job being run.
-      jsonPath: .status.build_id
-    - name: Type
-      type: string
-      description: The type of job being run.
-      jsonPath: .spec.type
-    - name: Org
-      type: string
-      description: The org for which the job is running.
-      jsonPath: .spec.refs.org
-    - name: Repo
-      type: string
-      description: The repo for which the job is running.
-      jsonPath: .spec.refs.repo
-    - name: Pulls
-      type: string
-      description: The pulls for which the job is running.
-      jsonPath: ".spec.refs.pulls[*].number"
-    - name: StartTime
-      type: date
-      description: When the job started running.
-      jsonPath: .status.startTime
-    - name: CompletionTime
-      type: date
-      description: When the job finished running.
-      jsonPath: .status.completionTime
-    - name: State
-      description: The state of the job.
-      type: string
-      jsonPath: .status.state
----
 apiVersion: apps/v1
 kind: Deployment
 metadata:

config/prow/cluster/tide_service.yaml

@@ -26,6 +26,8 @@ spec:
   - name: main
     port: 80
     targetPort: 8888
+    protocol: TCP
   - name: metrics
     port: 9090
+    protocol: TCP
   type: ClusterIP