Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support insecure 🍪s for testing Deck's GitHub oauth without SSL. #12989

Closed
cjwagner opened this issue Jun 12, 2019 · 8 comments
Closed

Support insecure 🍪s for testing Deck's GitHub oauth without SSL. #12989

cjwagner opened this issue Jun 12, 2019 · 8 comments
Labels
area/prow/deck Issues or PRs related to prow's deck component good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone
v1.16

Comments

@cjwagner
Copy link
Member

What would you like to be added:

A new boolean deck flag called --insecure-cookies that disables secure cookies so that Deck's GitHub oauth functionality will work without SSL.

Why is this needed:

I don't think this would be a safe option to enable for production instances, but it would be useful for testing without SSL.
@cjwagner cjwagner added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 12, 2019
@cjwagner
Copy link
Member Author

cc @mirandachrist @Katharine @stevekuznetsov
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@cjwagner:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

cc @mirandachrist @Katharine @stevekuznetsov
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 12, 2019
@cjwagner
Copy link
Member Author

/area prow/deck

@k8s-ci-robot k8s-ci-robot added the area/prow/deck Issues or PRs related to prow's deck component label Jun 12, 2019
@cjwagner cjwagner mentioned this issue Jun 12, 2019
Merged
@spiffxp
Copy link
Member

spiffxp commented Jul 26, 2019

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 26, 2019
@mirandachrist
Copy link
Contributor

Done in #13323 /close

@cjwagner
Copy link
Member Author

Commands must appear at the beginning of a line.
/close

@k8s-ci-robot
Copy link
Contributor

@cjwagner: Closing this issue.

In response to this:

Commands must appear at the beginning of a line.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Jul 29, 2019

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/prow/deck Issues or PRs related to prow's deck component good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
v1.16
Development

No branches or pull requests
4 participants
@spiffxp @cjwagner @k8s-ci-robot @mirandachrist