Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate merge-blocking jobs to dedicated cluster: pull-kubernetes-integration #18811

Closed
spiffxp opened this issue Aug 13, 2020 · 9 comments
Closed
Assignees
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@spiffxp
Copy link
Member

spiffxp commented Aug 13, 2020

Part of #18550

This is a trial balloon of a specific type of job (doesn't need an e2e project)

I'd like to get a sense of what sort of scaling jobs of this type are going to cause k8s-infra-prow-build. I'd also like to see whether this interferes with existing release-blocking job load. If so, we should consider a more boilerplate-filled approach of setting up a separate nodepool, and using taints/tolerations/nodeselectors for merge-blocking vs. release-blocking jobs.

I'm choosing pull-kubernetes-integration because it's the one I've seen flake the most lately. Getting it over to k8s-infra-prow-build will allow more community visibility, and ideally more resources thanks to autoscaling.

/area jobs
/wg k8s-infra
/sig testing
/sig release

@spiffxp spiffxp added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 13, 2020
@k8s-ci-robot k8s-ci-robot added area/jobs wg/k8s-infra sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 13, 2020
@spiffxp spiffxp changed the title Migrate merge-blocking jobs to k8s-infra-prow-build: pull-kubernetes-integration Migrate merge-blocking jobs to dedicated cluster: pull-kubernetes-integration Aug 13, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 13, 2020

Opened #18814

@spiffxp
Copy link
Member Author

spiffxp commented Aug 13, 2020

Spot check: looks good

One interesting quirk: pull-kubernetes-integration runs (the more frequent runs that start to occur further on the right) appear to use more memory than the ci variants. Not sure if this is branch-specific at all
Screen Shot 2020-08-13 at 7 31 10 AM

CPU usage looks comparable
Screen Shot 2020-08-13 at 7 31 36 AM

Will continue to evaluate as traffic grows over the day

@spiffxp
Copy link
Member Author

spiffxp commented Aug 14, 2020

/assign

@spiffxp
Copy link
Member Author

spiffxp commented Aug 14, 2020

OK it's pretty clear this job is healthier since it was migrated over
Screen Shot 2020-08-14 at 7 06 47 AM

Do we bother tuning resources now? Or wait until all jobs have moved over?

@spiffxp
Copy link
Member Author

spiffxp commented Aug 14, 2020

Just because it seemed pretty clear in this case, I'm lowring cpu from 7 to 6 to match the CI job, which is taking basically the same amount of time to run more tests. #18844

I'll hold this open to see the results, but am otherwise ready to call this done, and think other jobs of this type can be moved over

@spiffxp
Copy link
Member Author

spiffxp commented Aug 26, 2020

The presubmits-kubenetes-blocking testgrid doesn't go too far in history, so I can't show a lot of steady green. This was impacted by the same IO issues that plagued the CI variant of integration when we tried switching the build cluster from n1-highmem-8's to n1-highmem-16's (kubernetes/k8s.io#1173 (comment))

I think this is otherwise good to go, will poke at metrics explorer just to confirm good utilization

@spiffxp
Copy link
Member Author

spiffxp commented Aug 28, 2020

/close
Calling this done

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
Calling this done

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

2 participants