-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger the milestone applier on branch change in a PR #22095
Comments
/area prow |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
/sig testing |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What happened:
The milestone applier is set to be applied for all PRs targeting the 1.22 release branch for k/website, however, this PR targeted master by mistake. The PR was fixed, and is now targeting dev1.22 branch, however, the bot didn’t automatically apply the 1.22 milestone when the fix was done.
What you expected to happen:
The bot should retroactively apply the milestone applier if the branch has changed from a non-tracked or tracked one to the one reflected in the config.
How to reproduce it (as minimally and precisely as possible):
I haven't tested this out myself outside of the example provided above, but i think that if you open a PR targeting
master
branch and then switch todev-1.22
the bot should do nothing at all.Please provide links to example occurrences, if any:
kubernetes/website#27810
Anything else we need to know?:
Maybe this is intentional so that prow doesn't go around applying milestones creating side effects, would like to know if that's the case. if not, i'd be happy to fix this in an upcoming PR.
The text was updated successfully, but these errors were encountered: