Cherrypicker plugin: Find GitHub account and deploy

[alvaroaleman]

We added manifests and config for the cherrypicker plugin in #16329

However this is not quite enough because:

• It needs to use a different GitHub account, because Prow ignores events from itself
• It doesn't get deployed into the cluster yet

/cc @spiffxp @dims @vincepri

[alvaroaleman]

/sig testing

[cjwagner]

cc @mpherman2
/assign @droslean
The invalid config is spamming the Prow logs: "Post "http://cherrypicker": dial tcp: lookup cherrypicker on 10.111.240.10:53: no such host"

[spiffxp]

I'm gonna make an external cherry picker bot user for this

[spiffxp]

/assign

[alvaroaleman]

We added the deployment in #23471 and from the manifests and config it looks to me like it should work, however when trying it out it does not: kubernetes-sigs/controller-runtime#1640 (comment)

Could someone with access to the prow cluster check if its indeed deployed and running?

[cjwagner]

Could someone with access to the prow cluster check if its indeed deployed and running?

The deployment exists, but there are no associated pods. The deployment status includes this:

  - lastTransitionTime: "2021-09-08T15:05:51Z"
    lastUpdateTime: "2021-09-08T15:05:51Z"
    message: 'pods "cherrypicker-5d78d679f8-" is forbidden: error looking up service
      account default/cherrypicker: serviceaccount "cherrypicker" not found'
    reason: FailedCreate
    status: "True"
    type: ReplicaFailure

It doesn't look like we actually need a service account so I made a PR to remove the reference: #23517

[alvaroaleman]

It doesn't look like we actually need a service account so I made a PR to remove the reference: #23517

It still doesn't appear to be working unfortunately: kubernetes-sigs/controller-runtime#1640 (comment)

[spiffxp]

Still working on getting an account for you, it was flagged by abuse prevention on creation, still working on getting that addressed

[spiffxp]

OK after the following PR's:

• groups/sig-testing: add k8s-infra-cherrypick-robot k8s.io#2690
• bash/main: add k8s-infra-cherrypick-robot-github-token secret k8s.io#2693
• config/prow: add cherrypicker github token #23551
• bash/main: fix cherrypick secret iam k8s.io#2702

I believe https://github.com/k8s-infra-cherrypick-robot will open PRs. It's not yet an org member but I think this should be capable of working without that?

[spiffxp]

Not quite. Found a typo, #23556 should address

[spiffxp]

/priority important-soon
/milestone v1.23

[spiffxp]

Worked: kubernetes-sigs/controller-runtime#1661

I'd like to get the bot added as an org member before calling this done, is there anything else you can think of @alvaroaleman ?

[alvaroaleman]

I'd like to get the bot added as an org member before calling this done, is there anything else you can think of @alvaroaleman ?

Nope, that should be it. Thanks a lot for picking this up!