Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cherrypicker deployment in bazel prow configuration #23471

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

droslean
Copy link
Member

@droslean droslean commented Sep 3, 2021

In effort of solving #23469

Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 3, 2021
@droslean
Copy link
Member Author

droslean commented Sep 3, 2021

/hold

I am not sure if this is enough to deploy cherrypicker.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2021
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
@alvaroaleman
Copy link
Member

/cc @chaodaiG @cjwagner @mpherman2

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaodaiG, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@chaodaiG
Copy link
Contributor

chaodaiG commented Sep 8, 2021

I think this is all what we need for deploying cherrypicker in prow.k8s.io, it doesn't need RBAC right?

@droslean
Copy link
Member Author

droslean commented Sep 8, 2021

I think this is all what we need for deploying cherrypicker in prow.k8s.io, it doesn't need RBAC right?

Regarding the way that external-plugins work, they shouldn't need any special RBACs if they don't directly access a resource in the cluster. I think in cherrypicker case it doesn't need any.

Feel free to hold cancel, once you confirm this.

@alvaroaleman
Copy link
Member

No it doesn't need rbac, it just talks to github
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit eea057f into kubernetes:master Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow/bump Updates to the k8s prow cluster cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants