-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cherrypicker deployment in bazel prow configuration #23471
Conversation
/hold I am not sure if this is enough to deploy cherrypicker. |
Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
ea86af1
to
c8d37ec
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, droslean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this is all what we need for deploying cherrypicker in prow.k8s.io, it doesn't need RBAC right? |
Regarding the way that external-plugins work, they shouldn't need any special RBACs if they don't directly access a resource in the cluster. I think in Feel free to hold cancel, once you confirm this. |
No it doesn't need rbac, it just talks to github |
In effort of solving #23469
Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com