-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prow support for triggering jobs based on tag changes #5962
Comments
Also CC @Kargakis @stevekuznetsov @sebastienvas for potentially interested parties. As discussed on slack probably the most tricky part to supporting tag-triggered-jobs is deciding how we want the config to look. I'm not sure about the GPG checking details wit github but this also sounds potentially useful /area prow |
If we want to use these jobs for building and pushing releases we should probably get a trusted build cluster up and running otherwise your ProwJob running on a new tag won't have the credentials to do anything meaningful with whatever it builds. |
Yeah, it would be preferable to have #5848 first. We definitely plan to implement that one though. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Triggering jobs as a result of tags is something that sig-service-catalog is trying to do. |
this sort of thing would be a lot more straightforward to add if we decoupled job definitions and triggering |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Note that you can create a sequence of activity based on merge events, which we do in order to have prow update itself: https://testgrid.k8s.io/sig-testing-prow
|
this would be nice to have for github releases though to further automate publishing of tagged/named release versions, the main reason we can't implement this is how cludgey the triggering logic is now :( this should basically just be a post-submit triggered on tags being pushed. /remove-lifecycle rotten |
see this thread: #10802 (comment) |
So we already (inadvertently) support triggering jobs based on tag changes by using a postsubmit job with a branch regexp matching |
It would be useful to the cluster-registry if Prow could support triggering jobs based on GitHub
CreateEvent"
s.Concrete use case: I would like to be able to do cluster-registry releases without having to run tools locally on my machine, based on tags created by a GitHub release. If Prow can respond to GitHub
CreateEvent
s, then creating the tag can run the release process/upload binaries/etc. without requiring the person. This allows releases to be done by people who may not have write access to the GCP project that hosts the binaries, simply by creating aSubnote: it might be useful to know if a tag is verified, and to only start a release based on a verified, signed tag. cf https://help.github.com/articles/signing-tags-using-gpg/
The text was updated successfully, but these errors were encountered: