Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DNS image push yaml to trigger on new tags #19254

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Update DNS image push yaml to trigger on new tags #19254

merged 1 commit into from
Sep 16, 2020

Conversation

prameshj
Copy link
Contributor

Using '^\d+.\d+.\d+$' instead of 'refs/tags/\d+.\d+.\d+$' since it appears the prefix might be getting trimmed:
#5962 (comment)

/assign @fejta @BenTheElder @cjwagner

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2020
@prameshj
Copy link
Contributor Author

Fixes issue - #19242

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit c68e3af into kubernetes:master Sep 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 16, 2020
@k8s-ci-robot
Copy link
Contributor

@prameshj: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key k8s-staging-dns.yaml using file config/jobs/image-pushing/k8s-staging-dns.yaml

In response to this:

Using '^\d+.\d+.\d+$' instead of 'refs/tags/\d+.\d+.\d+$' since it appears the prefix might be getting trimmed:
#5962 (comment)

/assign @fejta @BenTheElder @cjwagner

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prameshj prameshj mentioned this pull request Sep 18, 2020
Merged
@prameshj
Copy link
Contributor Author

When would these changes take effect? I pushed a new tag to the DNS repo, but i am not seeing a new job kick in yet. - https://k8s-testgrid.appspot.com/sig-network-dns#dns-push-images
Does it require an update to pick up these changes?
@fejta

@spiffxp
Copy link
Member

spiffxp commented Sep 18, 2020

testgrid doesn't necessarily update as quickly, if you need to watch how things are going as quickly as possible keep an eye on https://prow.k8s.io (e.g. https://prow.k8s.io/?job=dns-push-images)

@spiffxp
Copy link
Member

spiffxp commented Sep 18, 2020

(and it looks like it did trigger, for tag 1.2.3)

@prameshj
Copy link
Contributor Author

Thanks Aaron! I see it too.. sorry for the false alarm.
I see the image tag generated is "v20200918-1.2.3", I was hoping to get just "1.2.3". Is any other config change required? This is the cloudbuild file i used - https://github.com/kubernetes/dns/blob/master/cloudbuild.yaml

@spiffxp
Copy link
Member

spiffxp commented Sep 18, 2020

Based on https://storage.googleapis.com/kubernetes-jenkins/logs/dns-push-images/1306945097224425472/podinfo.json I'm going to guess you want to use PULL_BASE_REF

prameshj added a commit to kubernetes/dns that referenced this pull request Sep 18, 2020
@prameshj
Use $_PULL_BASE_REF for the image tag.
b937acc 
As per recommendation in kubernetes/test-infra#19254 (comment)
@prameshj prameshj mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fejta fejta fejta approved these changes

@dims dims Awaiting requested review from dims

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

@fejta fejta

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@prameshj @k8s-ci-robot @spiffxp @fejta @BenTheElder @cjwagner