Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop notes about containerized kubelet #11339

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Drop notes about containerized kubelet #11339

merged 1 commit into from
Feb 20, 2019

Conversation

dims
Copy link
Member

@dims dims commented Feb 17, 2019

Please see kubernetes/kubernetes#74148

Change-Id: I4d261d272b18182d1ded9e91aa45d23b13d803af

@dims
Drop notes about containerized kubelet
bb9e31f 
Change-Id: I4d261d272b18182d1ded9e91aa45d23b13d803af
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 17, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 17, 2019
@dims
Copy link
Member Author

dims commented Feb 17, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2019
BenTheElder
BenTheElder approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fbb300a327cdc62b28ed305df35286cc34e38ec6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2019
@dims
Copy link
Member Author

dims commented Feb 20, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2019
@BenTheElder
Copy link
Member

/test pull-test-infra-verify-file-perms

@k8s-ci-robot k8s-ci-robot merged commit 74cb7d5 into kubernetes:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@cblecker cblecker Awaiting requested review from cblecker

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dims @k8s-ci-robot @BenTheElder