Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up Google Analytics to track when YAML button is clicked #13085

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Set up Google Analytics to track when YAML button is clicked #13085

merged 1 commit into from
Jun 20, 2019

Conversation

mirandachrist
Copy link
Contributor

/assign @cjwagner
/cc @fejta
/cc @Katharine

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 19, 2019
Katharine
Katharine suggested changes Jun 19, 2019
View reviewed changes
Copy link
Member

@Katharine Katharine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment, this PR pulls in a second (deprecated) copy of Google Analytics, which I doubt ends well. Instead, use the one we already have.

It's also preferable to pass around functions (which are first-class objects in JavaScript/TypeScript) instead of strings containing code, which then get eval()ed behind the scenes.

prow/cmd/deck/template/base.html Outdated Show resolved Hide resolved
prow/cmd/deck/static/common/common.ts Outdated Show resolved Hide resolved
prow/cmd/deck/static/common/common.ts Outdated Show resolved Hide resolved
prow/cmd/deck/static/prow/prow.ts Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 19, 2019
@fejta
Copy link
Contributor

fejta commented Jun 19, 2019

/uncc
Deferring to Katharine here

@k8s-ci-robot k8s-ci-robot removed the request for review from fejta June 19, 2019 23:28
Katharine
Katharine approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@Katharine Katharine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 32958c309deb8360685f94a7c373fe57e9fb0bde

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine, mirandachrist

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit 294d73f into kubernetes:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katharine Katharine Katharine approved these changes

Assignees

@Katharine Katharine

@cjwagner cjwagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/deck Issues or PRs related to prow's deck component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirandachrist @fejta @k8s-ci-robot @Katharine @cjwagner