Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include host in kubectl command #13117

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Include host in kubectl command #13117

merged 1 commit into from
Jun 21, 2019

Conversation

Katharine
Copy link
Member

This was mistakenly changed in #13008.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2019
@alvaroaleman
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 48edbea83e419ed60a9987f62678a8ec5d04981b

@alvaroaleman
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2019
alvaroaleman
alvaroaleman reviewed Jun 21, 2019
View reviewed changes
prow/cmd/deck/static/prow/prow.ts
@@ -658,7 +658,7 @@ function redraw(fz: FuzzySearch): void {
}

function createRerunCell(modal: HTMLElement, rerunElement: HTMLElement, prowjob: string): HTMLTableDataCellElement {
const url = `/rerun?prowjob=${prowjob}`;
const url = `${location.protocol}//${location.host}/rerun?prowjob=${prowjob}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing a colon or not?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

location.protocol includes the colon.

@fejta
Copy link
Contributor

fejta commented Jun 21, 2019

Alvaro would you want to add yourself as a reviewer in https://github.com/kubernetes/test-infra/blob/master/prow/OWNERS?

@alvaroaleman
Copy link
Member

Alvaro would you want to add yourself as a reviewer in https://github.com/kubernetes/test-infra/blob/master/prow/OWNERS?

Sure

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit b67b58d into kubernetes:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman left review comments

@fejta fejta Awaiting requested review from fejta

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@alvaroaleman alvaroaleman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/deck Issues or PRs related to prow's deck component area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Katharine @k8s-ci-robot @alvaroaleman @fejta